py/objstr: For str.endswith(s, start) raise NotImpl instead of assert.

dpgeorge · dpgeorge · commit 55b11e6d3873 · 2015-09-04T16:49:56.000+01:00
diff --git a/py/objstr.c b/py/objstr.c
@@ -699,7 +699,9 @@ STATIC mp_obj_t str_startswith(mp_uint_t n_args, const mp_obj_t *args) {
 STATIC mp_obj_t str_endswith(mp_uint_t n_args, const mp_obj_t *args) {
     GET_STR_DATA_LEN(args[0], str, str_len);
     GET_STR_DATA_LEN(args[1], suffix, suffix_len);
-    assert(n_args == 2);
+    if (n_args > 2) {
+        mp_not_implemented("start/end indices");
+    }
 
     if (suffix_len > str_len) {
         return mp_const_false;
diff --git a/tests/misc/non_compliant.py b/tests/misc/non_compliant.py
@@ -52,6 +52,12 @@
 except NotImplementedError:
     print('NotImplementedError')
 
+# str.endswith(s, start) not implemented
+try:
+    'abc'.endswith('c', 1)
+except NotImplementedError:
+    print('NotImplementedError')
+
 # bytes(...) with keywords not implemented
 try:
     bytes('abc', encoding='utf8')
diff --git a/tests/misc/non_compliant.py.exp b/tests/misc/non_compliant.py.exp
@@ -8,3 +8,4 @@ NotImplementedError
 NotImplementedError
 NotImplementedError
 NotImplementedError
+NotImplementedError
