JAVA-225: Create values() function for Insert builder using List.

Alexandre Dutra · olim7t · commit 294868c49392 · 2015-06-22T16:03:43.000+02:00
diff --git a/changelog/README.md b/changelog/README.md
@@ -12,6 +12,7 @@
 - [bug] Prevent QueryBuilder from trying to serialize raw string (JAVA-688)
 - [bug] Support bind marker in QueryBuilder DELETE's list index (JAVA-679)
 - [improvement] Improve QueryBuilder API for SELECT DISTINCT (JAVA-475)
+- [improvement] Create values() function for Insert builder using List (JAVA-225)
 
 Merged from 2.0.10_fixes branch:
 
diff --git a/driver-core/src/main/java/com/datastax/driver/core/querybuilder/Insert.java b/driver-core/src/main/java/com/datastax/driver/core/querybuilder/Insert.java
@@ -92,18 +92,30 @@ public Insert value(String name, Object value) {
      * value in {@code values} will be inserted for the {@code i}th column
      * in {@code names}.
      * @return this INSERT statement.
-     *
      * @throws IllegalArgumentException if {@code names.length != values.length}.
      */
     public Insert values(String[] names, Object[] values) {
-        if (names.length != values.length)
-            throw new IllegalArgumentException(String.format("Got %d names but %d values", names.length, values.length));
-        this.names.addAll(Arrays.asList(names));
-        this.values.addAll(Arrays.asList(values));
-
-        for (int i = 0; i < names.length; i++) {
-            checkForBindMarkers(values[i]);
-            maybeAddRoutingKey(names[i], values[i]);
+        return values(Arrays.asList(names), Arrays.asList(values));
+    }
+
+    /**
+     * Adds multiple column/value pairs to the values inserted by this INSERT statement.
+     *
+     * @param names a list of column names to insert/update.
+     * @param values a list of values to insert/update. The {@code i}th
+     * value in {@code values} will be inserted for the {@code i}th column
+     * in {@code names}.
+     * @return this INSERT statement.
+     * @throws IllegalArgumentException if {@code names.size() != values.size()}.
+     */
+    public Insert values(List<String> names, List<Object> values) {
+        if (names.size() != values.size())
+            throw new IllegalArgumentException(String.format("Got %d names but %d values", names.size(), values.size()));
+        this.names.addAll(names);
+        this.values.addAll(values);
+        for (int i = 0; i < names.size(); i++) {
+            checkForBindMarkers(values.get(i));
+            maybeAddRoutingKey(names.get(i), values.get(i));
         }
         return this;
     }
