Update Repository.prototype.getReferences to use changed libgit2 enum

John Haley · John Haley · commit 757df4701269 · 2015-06-08T15:23:32.000-07:00
diff --git a/examples/general.js b/examples/general.js
@@ -343,7 +343,7 @@ nodegit.Repository.open(path.resolve(__dirname, "../.git"))
     // references such as branches, tags and remote references (everything in
     // the .git/refs directory).
 
-    return repo.getReferenceNames(nodegit.Reference.TYPE.ALL);
+    return repo.getReferenceNames(nodegit.Reference.TYPE.LISTALL);
   })
 
   .then(function(referenceNames) {
diff --git a/lib/repository.js b/lib/repository.js
@@ -153,7 +153,7 @@ Repository.getReferences = function(repo, type, refNamesOnly, callback) {
     refList.forEach(function(refName) {
       refFilterPromises.push(Reference.lookup(repo, refName)
         .then(function(ref) {
-          if (type == Reference.TYPE.ALL || ref.type() == type) {
+          if (type == Reference.TYPE.LISTALL || ref.type() == type) {
             if (refNamesOnly) {
               filteredRefs.push(refName);
               return;
@@ -164,6 +164,9 @@ Repository.getReferences = function(repo, type, refNamesOnly, callback) {
                 resolvedRef.repo = repo;
 
                 filteredRefs.push(resolvedRef);
+              })
+              .catch(function() {
+                // If we can't resolve the ref then just ignore it.
               });
             }
             else {
