chore: update SQL Server samples to not require host (GoogleCloudPlatform#9157)

jackwotherspoon · web-flow · commit 67c40761174c · 2023-02-21T12:59:21.000-05:00
diff --git a/cloud-sql/sql-server/client-side-encryption/snippets/cloud_sql_connection_pool.py b/cloud-sql/sql-server/client-side-encryption/snippets/cloud_sql_connection_pool.py
@@ -45,7 +45,7 @@ def connect_with_pytds() -> pytds.Connection:
     pool = sqlalchemy.create_engine(
         # This allows us to use the pytds sqlalchemy dialect, but also set the
         # bytes_to_unicode flag to False, which is not supported by the dialect
-        "mssql+pytds://localhost",
+        "mssql+pytds://",
         creator=connect_with_pytds,
     )
 
diff --git a/cloud-sql/sql-server/sqlalchemy/connect_connector.py b/cloud-sql/sql-server/sqlalchemy/connect_connector.py
@@ -63,7 +63,7 @@ def getconn() -> pytds.Connection:
         return conn
 
     pool = sqlalchemy.create_engine(
-        "mssql+pytds://localhost",
+        "mssql+pytds://",
         creator=getconn,
         # [START_EXCLUDE]
         # Pool size is the maximum number of permanent connections to keep.
diff --git a/cloud-sql/sql-server/sqlalchemy/connection_test.py b/cloud-sql/sql-server/sqlalchemy/connection_test.py
@@ -95,6 +95,6 @@ def test_cast_vote(client: FlaskClient) -> None:
 def test_connector_connection(client: FlaskClient) -> None:
     del os.environ["INSTANCE_HOST"]
     app.db = app.init_connection_pool()
-    assert str(app.db.url) == "mssql+pytds://localhost"
+    assert str(app.db.url) == "mssql+pytds://"
     test_get_votes(client)
     test_cast_vote(client)

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ def connect_with_pytds() -> pytds.Connection:`
`45`	`45`	`pool = sqlalchemy.create_engine(`
`46`	`46`	`# This allows us to use the pytds sqlalchemy dialect, but also set the`
`47`	`47`	`# bytes_to_unicode flag to False, which is not supported by the dialect`
`48`		`- "mssql+pytds://localhost",`
	`48`	`+ "mssql+pytds://",`
`49`	`49`	`creator=connect_with_pytds,`
`50`	`50`	`)`
`51`	`51`