fix(styling): change transform parameters parsing (NativeScript#9481)

SergeyMell · NathanWalker · commit 2a4563716aa1 · 2021-09-08T16:07:39.000-07:00
Fixed the incorrectly applied short form of "transform: translate" style property. closes NativeScript#5202
diff --git a/apps/automated/src/ui/animation/css-animation-tests.ts b/apps/automated/src/ui/animation/css-animation-tests.ts
@@ -212,7 +212,7 @@ export function test_ReadTranslateSingle() {
 
 	TKUnit.assertEqual(translate.property, 'translate');
 	TKUnit.assertAreClose(translate.value.x, 30, DELTA);
-	TKUnit.assertAreClose(translate.value.y, 30, DELTA);
+	TKUnit.assertAreClose(translate.value.y, 0, DELTA);
 }
 
 export function test_ReadTranslateXY() {
diff --git a/packages/core/ui/styling/style-properties.ts b/packages/core/ui/styling/style-properties.ts
@@ -736,7 +736,13 @@ function normalizeTransformation({ property, value }: Transformation): Transform
 }
 
 function convertTransformValue(property: string, stringValue: string): TransformationValue {
-	const [x, y = x, z = y] = stringValue.split(',').map(parseFloat);
+	let [x, y, z] = stringValue.split(',').map(parseFloat);
+	if (property === 'translate') {
+		y ??= IDENTITY_TRANSFORMATION.translate.y;
+	} else {
+		y ??= x;
+		z ??= y;
+	}
 
 	if (property === 'rotate' || property === 'rotateX' || property === 'rotateY') {
 		return stringValue.slice(-3) === 'rad' ? radiansToDegrees(x) : x;

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ export function test_ReadTranslateSingle() {`
`212`	`212`
`213`	`213`	`TKUnit.assertEqual(translate.property, 'translate');`
`214`	`214`	`TKUnit.assertAreClose(translate.value.x, 30, DELTA);`
`215`		`- TKUnit.assertAreClose(translate.value.y, 30, DELTA);`
	`215`	`+ TKUnit.assertAreClose(translate.value.y, 0, DELTA);`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`export function test_ReadTranslateXY() {`