Skip to content

Commit edbaf87

Browse files
committed
Retry on 500 from 'descriptor.{create,delete}'.
Toward googleapis#2176.
1 parent fd0e6bf commit edbaf87

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

system_tests/monitoring.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
from gcloud import _helpers
1818
from gcloud.environment_vars import TESTS_PROJECT
19+
from gcloud.exceptions import InternalServerError
1920
from gcloud.exceptions import NotFound
2021
from gcloud.exceptions import ServiceUnavailable
2122
from gcloud import monitoring
@@ -24,6 +25,8 @@
2425
from system_test_utils import unique_resource_id
2526

2627
retry_404 = RetryErrors(NotFound)
28+
retry_404_500 = RetryErrors((NotFound, InternalServerError))
29+
retry_500 = RetryErrors(InternalServerError)
2730
retry_503 = RetryErrors(ServiceUnavailable)
2831

2932

@@ -176,8 +179,8 @@ def test_create_and_delete_metric_descriptor(self):
176179
description=DESCRIPTION,
177180
)
178181

179-
descriptor.create()
180-
retry_404(descriptor.delete)()
182+
retry_500(descriptor.create())
183+
retry_404_500(descriptor.delete)()
181184

182185
with self.assertRaises(NotFound):
183186
descriptor.delete()

0 commit comments

Comments
 (0)