I/O: Make I2C & SPI accept ints for write()

gohai · gohai · commit 807833fd9697 · 2015-10-12T16:56:01.000+02:00
This makes everyone's sketches a bit lighter, since it is not longer necessary to explicitly cast to byte or call byte(). Instead, we throw an exception if the value does not fit into the byte.
diff --git a/java/libraries/io/src/processing/io/I2C.java b/java/libraries/io/src/processing/io/I2C.java
@@ -221,19 +221,23 @@ public void write(String out) {
 
 
   /**
-   *  Adds bytes to be written to the device
+   *  Adds a byte to be written to the device
    *
    *  You must call beginTransmission() before calling this function.
    *  The actual writing takes part when read() or endTransmission() is being
    *  called.
-   *  @param out single byte to be written
+   *  @param out single byte to be written (0-255)
    *  @see beginTransmission
    *  @see read
    *  @see endTransmission
    */
-  public void write(byte out) {
+  public void write(int out) {
+    if (out < 0 || 255 < out) {
+      System.err.println("The write function can only operate on a single byte at a time. Call it with a value from 0 to 255.");
+      throw new RuntimeException("Argument does not fit into a single byte");
+    }
     byte[] tmp = new byte[1];
-    tmp[0] = out;
+    tmp[0] = (byte)out;
     write(tmp);
   }
 }
diff --git a/java/libraries/io/src/processing/io/SPI.java b/java/libraries/io/src/processing/io/SPI.java
@@ -171,9 +171,13 @@ public byte[] transfer(String out) {
    *  @param out single byte to send
    *  @return bytes read in (array is the same length as out)
    */
-  public byte[] transfer(byte out) {
+  public byte[] transfer(int out) {
+    if (out < 0 || 255 < out) {
+      System.err.println("The transfer function can only operate on a single byte at a time. Call it with a value from 0 to 255.");
+      throw new RuntimeException("Argument does not fit into a single byte");
+    }
     byte[] tmp = new byte[1];
-    tmp[0] = out;
+    tmp[0] = (byte)out;
     return transfer(tmp);
   }
 }
