ci: validate that every package have a BUILD file

hansl · hansl · commit 6dbfc4d6ec80 · 2018-06-05T17:55:18.000-07:00
diff --git a/packages/angular/pwa/BUILD b/packages/angular/pwa/BUILD
diff --git a/scripts/validate-build-files.ts b/scripts/validate-build-files.ts
@@ -0,0 +1,40 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+// tslint:disable:no-implicit-dependencies
+import { logging, tags } from '@angular-devkit/core';
+import { existsSync } from 'fs';
+import { join } from 'path';
+import { packages } from '../lib/packages';
+
+export default function (_options: {}, logger: logging.Logger) {
+  let error = false;
+
+  for (const pkgName of Object.keys(packages)) {
+    const pkg = packages[pkgName];
+
+    if (pkg.packageJson.private) {
+      // Ignore private packages.
+      continue;
+    }
+
+    // There should be at least one BUILD file next to each package.json.
+    if (!existsSync(join(pkg.root, 'BUILD'))) {
+      logger.error(tags.oneLine`
+        The package ${JSON.stringify(pkgName)} does not have a BUILD file associated to it. You
+        must either set an exception or make sure it can be built using Bazel.
+      `);
+      error = true;
+    }
+  }
+
+  // TODO: enable this to break
+  if (error) {
+    // process.exit(1);
+    logger.warn('Found some BUILD files missing, which will be breaking your PR soon.');
+  }
+}
diff --git a/scripts/validate.ts b/scripts/validate.ts
@@ -9,6 +9,7 @@
 import { logging, tags } from '@angular-devkit/core';
 import { execSync } from 'child_process';
 import templates from './templates';
+import validateBuildFiles from './validate-build-files';
 import validateCommits from './validate-commits';
 import validateLicenses from './validate-licenses';
 
@@ -45,6 +46,10 @@ export default function (options: { verbose: boolean }, logger: logging.Logger)
   logger.info('Running license validation...');
   validateLicenses({}, logger.createChild('validate-commits'));
 
+  logger.info('');
+  logger.info('Running BUILD files validation...');
+  validateBuildFiles({}, logger.createChild('validate-build-files'));
+
   if (error) {
     process.exit(101);
   }
