test: avoid calling jasmine done with error

clydin · hansl · commit 4783e6e63ff6 · 2018-06-05T17:55:19.000-07:00
diff --git a/packages/angular_devkit/build_angular/test/browser/assets_spec_large.ts b/packages/angular_devkit/build_angular/test/browser/assets_spec_large.ts
@@ -69,7 +69,7 @@ describe('Browser Builder assets', () => {
       }],
     };
 
-    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, done, done.fail);
+    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, () => done(), done.fail);
 
     // The node_modules folder must be deleted, otherwise code that tries to find the
     // node_modules folder will hit this one and can fail.
@@ -85,7 +85,7 @@ describe('Browser Builder assets', () => {
       assets: ['not-source-root/file.txt'],
     };
 
-    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, done, done.fail);
+    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, () => done(), done.fail);
 
     // The node_modules folder must be deleted, otherwise code that tries to find the
     // node_modules folder will hit this one and can fail.
diff --git a/packages/angular_devkit/build_angular/test/browser/output-path_spec_large.ts b/packages/angular_devkit/build_angular/test/browser/output-path_spec_large.ts
@@ -37,6 +37,6 @@ describe('Browser Builder output path', () => {
   it('does not allow output path to be project root', (done) => {
     const overrides = { outputPath: './' };
 
-    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, done, done.fail);
+    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, () => done(), done.fail);
   }, Timeout.Basic);
 });
diff --git a/packages/angular_devkit/build_angular/test/browser/replacements_spec_large.ts b/packages/angular_devkit/build_angular/test/browser/replacements_spec_large.ts
@@ -82,7 +82,7 @@ describe('Browser Builder file replacements', () => {
       ],
     };
 
-    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, done, done.fail);
+    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, () => done(), done.fail);
   }, Timeout.Basic);
 
   it(`fails compilation with missing 'with' file`, (done) => {
@@ -95,6 +95,6 @@ describe('Browser Builder file replacements', () => {
       ],
     };
 
-    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, done, done.fail);
+    runTargetSpec(host, browserTargetSpec, overrides).subscribe(undefined, () => done(), done.fail);
   }, Timeout.Basic);
 });
diff --git a/packages/angular_devkit/build_angular/test/browser/service-worker_spec_large.ts b/packages/angular_devkit/build_angular/test/browser/service-worker_spec_large.ts
@@ -47,7 +47,7 @@ describe('Browser Builder', () => {
     runTargetSpec(host, browserTargetSpec, overrides)
       .subscribe(event => {
         expect(event.success).toBe(false);
-      }, done, done.fail);
+      }, () => done(), done.fail);
   }, Timeout.Basic);
 
   it('works with service worker', (done) => {
diff --git a/packages/angular_devkit/build_angular/test/dev-server/proxy_spec_large.ts b/packages/angular_devkit/build_angular/test/dev-server/proxy_spec_large.ts
@@ -54,6 +54,6 @@ describe('Dev Server Builder proxy', () => {
     const overrides: Partial<DevServerBuilderOptions> = { proxyConfig: '../proxy.config.json' };
 
     runTargetSpec(host, devServerTargetSpec, overrides)
-      .subscribe(undefined, done, done.fail);
+      .subscribe(undefined, () => done(), done.fail);
   }, 30000);
 });
diff --git a/packages/angular_devkit/build_angular/test/protractor/works_spec_large.ts b/packages/angular_devkit/build_angular/test/protractor/works_spec_large.ts
@@ -33,7 +33,7 @@ describe('Protractor Builder', () => {
 
     runTargetSpec(host, protractorTargetSpec, overrides).pipe(
       // This should fail because no server is available for connection.
-    ).subscribe(undefined, done, done.fail);
+    ).subscribe(undefined, () => done(), done.fail);
   }, 30000);
 
   linuxOnlyIt('overrides protractor specs', (done) => {
diff --git a/packages/angular_devkit/build_angular/test/tslint/works_spec_large.ts b/packages/angular_devkit/build_angular/test/tslint/works_spec_large.ts
@@ -164,6 +164,6 @@ describe('Tslint Target', () => {
     };
 
     runTargetSpec(host, tslintTargetSpec, overrides).pipe(
-    ).subscribe(undefined, done, done.fail);
+    ).subscribe(undefined, () => done(), done.fail);
   }, 30000);
 });
