Fixed to handle error code 127 as well (command not found) #148 #178

DonJayamanne · DonJayamanne · commit c6582338cd03 · 2016-06-22T15:48:44.000+10:00
diff --git a/src/client/common/utils.ts b/src/client/common/utils.ts
@@ -110,13 +110,13 @@ export function execPythonFile(file: string, args: string[], cwd: string, includ
             return execFileInternal(file, args, cwd, includeErrorAsResponse);
         }
         // return what ever error we got from the previous process
-        Promise.reject(error);
+        return Promise.reject(error);
     });
 }
 
 function handleResponse(error: Error, stdout: string, stderr: string, file: string, includeErrorAsResponse: boolean, rejectIfENOENTErrors: boolean = false): Promise<string> {
     return new Promise<string>((resolve, reject) => {
-        if (error && (<any>error).code === "ENOENT" && rejectIfENOENTErrors) {
+        if (error && ((<any>error).code === "ENOENT") || (<any>error).code === 127) {
             if (!IN_VALID_FILE_PATHS.has(file)) {
                 IN_VALID_FILE_PATHS.set(file, true);
             }
diff --git a/src/client/linters/baseLinter.ts b/src/client/linters/baseLinter.ts
@@ -107,7 +107,7 @@ export abstract class BaseLinter {
                 });
 
                 resolve(diagnostics);
-            }, error => {
+            }).catch(error => {
                 outputChannel.appendLine(`Linting with ${linterId} failed. If not installed please turn if off in settings.\n ${error}`);
                 window.showInformationMessage(`Linting with ${linterId} failed. If not installed please turn if off in settings. View Python output for details.`);
             });
diff --git a/src/client/providers/lintProvider.ts b/src/client/providers/lintProvider.ts
@@ -131,6 +131,7 @@ export class LintProvider extends vscode.Disposable {
 
             this.diagnosticCollection.delete(documentUri);
             this.diagnosticCollection.set(documentUri, messages);
+        }).catch(error => {
         });
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -110,13 +110,13 @@ export function execPythonFile(file: string, args: string[], cwd: string, includ`
`110`	`110`	`return execFileInternal(file, args, cwd, includeErrorAsResponse);`
`111`	`111`	`}`
`112`	`112`	`// return what ever error we got from the previous process`
`113`		`- Promise.reject(error);`
	`113`	`+ return Promise.reject(error);`
`114`	`114`	`});`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`function handleResponse(error: Error, stdout: string, stderr: string, file: string, includeErrorAsResponse: boolean, rejectIfENOENTErrors: boolean = false): Promise<string> {`
`118`	`118`	`return new Promise<string>((resolve, reject) => {`
`119`		`- if (error && (<any>error).code === "ENOENT" && rejectIfENOENTErrors) {`
	`119`	`+ if (error && ((<any>error).code === "ENOENT") \|\| (<any>error).code === 127) {`
`120`	`120`	`if (!IN_VALID_FILE_PATHS.has(file)) {`
`121`	`121`	`IN_VALID_FILE_PATHS.set(file, true);`
`122`	`122`	`}`
Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ export class LintProvider extends vscode.Disposable {`
`131`	`131`
`132`	`132`	`this.diagnosticCollection.delete(documentUri);`
`133`	`133`	`this.diagnosticCollection.set(documentUri, messages);`
	`134`	`+ }).catch(error => {`
`134`	`135`	`});`
`135`	`136`	`}`
`136`	`137`	`}`