bug: abs returns 0 on an empty array (TheAlgorithms#1473)

ridge-kimani · rnkimani · web-flow · commit c5a25665e0aa · 2023-10-10T12:34:09.000+05:30
* bug: update edge case for empty array

* bug: add edge case for empty arrays

* feat: add test case for empty array

---------

Co-authored-by: Ridge Kimani &lt;ridgekimani@gmail.com&gt;
diff --git a/Maths/Abs.js b/Maths/Abs.js
@@ -12,11 +12,11 @@
 const abs = (num) => {
   const validNumber = +num // converted to number, also can use - Number(num)
 
-  if (Number.isNaN(validNumber)) {
+  if (Number.isNaN(validNumber) || typeof num === 'object') {
     throw new TypeError('Argument is NaN - Not a Number')
   }
 
-  return validNumber < 0 ? -validNumber : validNumber // if number is less then zero mean negative then it converted to positive. i.e -> n = -2 = -(-2) = 2
+  return validNumber < 0 ? -validNumber : validNumber // if number is less than zero mean negative then it converted to positive. i.e -> n = -2 = -(-2) = 2
 }
 
 export { abs }
diff --git a/Maths/test/Abs.test.js b/Maths/test/Abs.test.js
@@ -5,6 +5,7 @@ describe('Testing abs function', () => {
     expect(() => abs('234a')).toThrow()
     expect(() => abs({})).toThrow()
     expect(() => abs([12, -32, -60])).toThrow()
+    expect(() => abs([])).toThrow() // coerces to 0
   })
 
   it('Testing for number of string type', () => {

Original file line number	Diff line number	Diff line change
`@@ -12,11 +12,11 @@`
`12`	`12`	`const abs = (num) => {`
`13`	`13`	`const validNumber = +num // converted to number, also can use - Number(num)`
`14`	`14`
`15`		`- if (Number.isNaN(validNumber)) {`
	`15`	`+ if (Number.isNaN(validNumber) \|\| typeof num === 'object') {`
`16`	`16`	`throw new TypeError('Argument is NaN - Not a Number')`
`17`	`17`	`}`
`18`	`18`
`19`		`- return validNumber < 0 ? -validNumber : validNumber // if number is less then zero mean negative then it converted to positive. i.e -> n = -2 = -(-2) = 2`
	`19`	`+ return validNumber < 0 ? -validNumber : validNumber // if number is less than zero mean negative then it converted to positive. i.e -> n = -2 = -(-2) = 2`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`export { abs }`