Draft
Conversation
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every time you run
dagger functions, the engine calls the SDK'smoduleTypeshook, which runs live codegen inside a container just to figure out what functions and types your module exposes. This is slow and unnecessary — the answer only changes when your source code changes.Solution
Move typedef discovery out of runtime. During
dagger generate, persist the module's type definitions as a checked-in artifact (dagger.moduletypes.json). At load time, read that file instead of running SDK codegen. Keep the live codegen path as a fallback for bootstrap and stale artifacts.Design
This PR is a first step + handoff draft:
ModuleTypes()— reusebaseWithCodegen()instead of duplicating ~45 lines of container setup. Same behavior, less code.dagger functionsinit()doesn't run during typedef loadingdagger functionsbecomes a file read instead of a codegen run