Skip to content

Commit bddac83

Browse files
committed
ci: always show the installer.log
We do log the output into a file so that it can be inspected, but currently the output is not shown unless the installation succeeded. That's bad. We need the output _particularly_ when the installation failed. Let's just print it in a separate step, making sure that it is printed whenever the installation fails. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 3839122 commit bddac83

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/main.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,14 +206,15 @@ jobs:
206206
"$env:ProgramFiles\Git\usr\bin" | Out-File -Encoding ascii -Append $env:GITHUB_PATH
207207
"$env:ProgramFiles\Git\mingw${{ matrix.bitness }}\bin" | Out-File -Encoding ascii -Append $env:GITHUB_PATH
208208
}
209+
- name: show installer log
210+
# run this even if the installation failed (actually, _in particular_ when the installation failed)
211+
if: always() && matrix.artifact == 'build-installers'
212+
shell: bash
213+
run: cat installer.log
209214
- name: validate
210215
if: matrix.artifact == 'build-installers'
211216
shell: bash
212217
run: |
213-
echo '::group::installer.log'
214-
cat installer.log
215-
echo '::endgroup'
216-
217218
set -x &&
218219
grep 'Installation process succeeded' installer.log &&
219220
! grep -iw failed installer.log &&

0 commit comments

Comments
 (0)