Cast identifier names to string in lint rule (microsoft#17027)

weswigham · web-flow · commit f888c88f31c6 · 2017-07-07T16:30:02.000-07:00
To be compatible with both the current version of the compiler and the nightly (which uses a branded string for the text member).
diff --git a/scripts/tslint/booleanTriviaRule.ts b/scripts/tslint/booleanTriviaRule.ts
@@ -27,7 +27,7 @@ function walk(ctx: Lint.WalkContext<void>): void {
     /** Skip certain function/method names whose parameter names are not informative. */
     function shouldIgnoreCalledExpression(expression: ts.Expression): boolean {
         if (expression.kind === ts.SyntaxKind.PropertyAccessExpression) {
-            const methodName = (expression as ts.PropertyAccessExpression).name.text;
+            const methodName = (expression as ts.PropertyAccessExpression).name.text as string;
             if (methodName.indexOf("set") === 0) {
                 return true;
             }
@@ -44,7 +44,7 @@ function walk(ctx: Lint.WalkContext<void>): void {
             }
         }
         else if (expression.kind === ts.SyntaxKind.Identifier) {
-            const functionName = (expression as ts.Identifier).text;
+            const functionName = (expression as ts.Identifier).text as string;
             if (functionName.indexOf("set") === 0) {
                 return true;
             }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ function walk(ctx: Lint.WalkContext<void>): void {`
`27`	`27`	`/** Skip certain function/method names whose parameter names are not informative. */`
`28`	`28`	`function shouldIgnoreCalledExpression(expression: ts.Expression): boolean {`
`29`	`29`	`if (expression.kind === ts.SyntaxKind.PropertyAccessExpression) {`
`30`		`- const methodName = (expression as ts.PropertyAccessExpression).name.text;`
	`30`	`+ const methodName = (expression as ts.PropertyAccessExpression).name.text as string;`
`31`	`31`	`if (methodName.indexOf("set") === 0) {`
`32`	`32`	`return true;`
`33`	`33`	`}`
`@@ -44,7 +44,7 @@ function walk(ctx: Lint.WalkContext<void>): void {`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`	`else if (expression.kind === ts.SyntaxKind.Identifier) {`
`47`		`- const functionName = (expression as ts.Identifier).text;`
	`47`	`+ const functionName = (expression as ts.Identifier).text as string;`
`48`	`48`	`if (functionName.indexOf("set") === 0) {`
`49`	`49`	`return true;`
`50`	`50`	`}`