httpserver: follow-up werkzeug's header type change

csernazs · csernazs · commit 81c15ef14cc1 · 2023-05-16T20:44:55.000+02:00
diff --git a/pytest_httpserver/httpserver.py b/pytest_httpserver/httpserver.py
@@ -34,8 +34,8 @@
 METHOD_ALL = "__ALL"
 
 HEADERS_T = Union[
-    Mapping[str, Union[str, int, Iterable[Union[str, int]]]],
-    Iterable[Tuple[str, Union[str, int]]],
+    Mapping[str, Union[str, Iterable[str]]],
+    Iterable[Tuple[str, str]],
 ]
 
 HVMATCHER_T = Callable[[str, Optional[str], str], bool]
diff --git a/releasenotes/notes/werkzeug-header-type-follow-up-74a80dd03e6ca6db.yaml b/releasenotes/notes/werkzeug-header-type-follow-up-74a80dd03e6ca6db.yaml
@@ -0,0 +1,4 @@
+---
+upgrade:
+  - With werkzeug 2.3.x the headers type has been updated to not allow integers
+    as header values. This restriction followed up in pytest-httpserver.
diff --git a/tests/test_headers.py b/tests/test_headers.py
@@ -82,15 +82,14 @@ def test_authorization_headers(httpserver: HTTPServer):
 def test_header_one_key_multiple_values(httpserver: HTTPServer):
     httpserver.expect_request(uri="/t1").respond_with_data(headers=[("X-Foo", "123"), ("X-Foo", "456")])
     httpserver.expect_request(uri="/t2").respond_with_data(headers={"X-Foo": ["123", "456"]})
-    httpserver.expect_request(uri="/t3").respond_with_data(headers={"X-Foo": [123, 456]})
 
     headers = Headers()
     headers.add("X-Foo", "123")
     headers.add("X-Foo", "456")
 
-    httpserver.expect_request(uri="/t4").respond_with_data(headers=headers)
+    httpserver.expect_request(uri="/t3").respond_with_data(headers=headers)
 
-    for uri in ("/t1", "/t2", "/t3", "/t4"):
+    for uri in ("/t1", "/t2", "/t3"):
         conn = http.client.HTTPConnection("localhost:{}".format(httpserver.port))
         conn.request("GET", uri)
         response = conn.getresponse()

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,8 @@`
`34`	`34`	`METHOD_ALL = "__ALL"`
`35`	`35`
`36`	`36`	`HEADERS_T = Union[`
`37`		`- Mapping[str, Union[str, int, Iterable[Union[str, int]]]],`
`38`		`- Iterable[Tuple[str, Union[str, int]]],`
	`37`	`+ Mapping[str, Union[str, Iterable[str]]],`
	`38`	`+ Iterable[Tuple[str, str]],`
`39`	`39`	`]`
`40`	`40`
`41`	`41`	`HVMATCHER_T = Callable[[str, Optional[str], str], bool]`