CFunctions' doc strings should be Unicode.

gvanrossum · gvanrossum · commit 23ad7ca287c9 · 2007-08-23T23:35:15.000Z
diff --git a/Objects/methodobject.c b/Objects/methodobject.c
@@ -135,7 +135,7 @@ meth_get__doc__(PyCFunctionObject *m, void *closure)
 	const char *doc = m->m_ml->ml_doc;
 
 	if (doc != NULL)
-		return PyString_FromString(doc);
+		return PyUnicode_FromString(doc);
 	Py_INCREF(Py_None);
 	return Py_None;
 }
@@ -284,7 +284,7 @@ Py_FindMethodInChain(PyMethodChain *chain, PyObject *self, const char *name)
 		if (strcmp(name, "__doc__") == 0) {
 			const char *doc = self->ob_type->tp_doc;
 			if (doc != NULL)
-				return PyString_FromString(doc);
+				return PyUnicode_FromString(doc);
 		}
 	}
 	while (chain != NULL) {

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ meth_get__doc__(PyCFunctionObject m, void closure)`
`135`	`135`	`const char *doc = m->m_ml->ml_doc;`
`136`	`136`
`137`	`137`	`if (doc != NULL)`
`138`		`- return PyString_FromString(doc);`
	`138`	`+ return PyUnicode_FromString(doc);`
`139`	`139`	`Py_INCREF(Py_None);`
`140`	`140`	`return Py_None;`
`141`	`141`	`}`
`@@ -284,7 +284,7 @@ Py_FindMethodInChain(PyMethodChain chain, PyObject self, const char *name)`
`284`	`284`	`if (strcmp(name, "__doc__") == 0) {`
`285`	`285`	`const char *doc = self->ob_type->tp_doc;`
`286`	`286`	`if (doc != NULL)`
`287`		`- return PyString_FromString(doc);`
	`287`	`+ return PyUnicode_FromString(doc);`
`288`	`288`	`}`
`289`	`289`	`}`
`290`	`290`	`while (chain != NULL) {`