Users: Make sure wp_logout() clears current user, so that a subsequent call to is_user_logged_in() works as expected.

SergeyBiryukov · SergeyBiryukov · commit a8259b8c5ee1 · 2019-10-12T03:08:56.000Z
Props sebastian.pisula, donmhico, roytanck, juliobox. Fixes #35488. git-svn-id: https://develop.svn.wordpress.org/trunk@46467 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/pluggable.php b/src/wp-includes/pluggable.php
@@ -571,6 +571,7 @@ function wp_authenticate( $username, $password ) {
 	function wp_logout() {
 		wp_destroy_current_session();
 		wp_clear_auth_cookie();
+		wp_set_current_user( 0 );
 
 		/**
 		 * Fires after a user is logged-out.
diff --git a/tests/phpunit/tests/user/capabilities.php b/tests/phpunit/tests/user/capabilities.php
@@ -1750,7 +1750,6 @@ function test_require_edit_others_posts_if_post_type_doesnt_exist() {
 	 * @ticket 17253
 	 */
 	function test_cpt_with_page_capability_type() {
-
 		register_post_type(
 			'page_capability',
 			array(
@@ -1799,8 +1798,7 @@ function test_cpt_with_page_capability_type() {
 
 	}
 
-	public function testNonLoggedInUsersHaveNoCapabilities() {
-
+	public function test_non_logged_in_users_have_no_capabilities() {
 		$this->assertFalse( is_user_logged_in() );
 
 		$caps = $this->getAllCapsAndRoles();
@@ -1817,6 +1815,20 @@ public function testNonLoggedInUsersHaveNoCapabilities() {
 		$this->assertFalse( current_user_can( 'do_not_allow' ), 'Non-logged-in user should not have the do_not_allow capability' );
 	}
 
+	/**
+	 * @ticket 35488
+	 */
+	function test_wp_logout_should_clear_current_user() {
+		$user_id = self::factory()->user->create();
+		wp_set_current_user( $user_id );
+
+		wp_logout();
+
+		$this->assertEquals( 0, get_current_user_id() );
+
+	}
+
+
 	protected $_role_test_wp_roles_role;
 	/**
 	 * @ticket 23016
