implement async version getting Request Token for OAuth 1.0a

s-gromov · s-gromov · commit 545f2d55288c · 2016-06-06T15:52:52.000+03:00
diff --git a/changelog b/changelog
@@ -2,6 +2,7 @@
  * make http async client implementation be more pluggable
  * add async-http-client 2.0 support (thanks to Sai Chandrasekharan https://github.com/saichand)
  * add Misfit (http://misfit.com/) API
+ * implement async version getting Request Token for OAuth 1.0a
 
 [2.6.0]
  * simplify async/sync usages
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth10aService.java b/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth10aService.java
@@ -40,15 +40,12 @@ public OAuth10aService(DefaultApi10a api, OAuthConfig config) {
      *
      * @return request token
      */
-    public OAuth1RequestToken getRequestToken() {
+    public final OAuth1RequestToken getRequestToken() {
         final OAuthConfig config = getConfig();
         config.log("obtaining request token from " + api.getRequestTokenEndpoint());
         final OAuthRequest request = new OAuthRequest(api.getRequestTokenVerb(), api.getRequestTokenEndpoint(), this);
 
-        config.log("setting oauth_callback to " + config.getCallback());
-        request.addOAuthParameter(OAuthConstants.CALLBACK, config.getCallback());
-        addOAuthParams(request, "");
-        appendSignature(request);
+        prepareRequestTokenRequest(request);
 
         config.log("sending request...");
         final Response response = request.send();
@@ -59,6 +56,29 @@ public OAuth1RequestToken getRequestToken() {
         return api.getRequestTokenExtractor().extract(body);
     }
 
+    public final Future<OAuth1RequestToken> getRequestTokenAsync(
+            OAuthAsyncRequestCallback<OAuth1RequestToken> callback) {
+        final OAuthConfig config = getConfig();
+        config.log("async obtaining request token from " + api.getRequestTokenEndpoint());
+        final OAuthRequestAsync request
+                = new OAuthRequestAsync(api.getRequestTokenVerb(), api.getRequestTokenEndpoint(), this);
+        prepareRequestTokenRequest(request);
+        return request.sendAsync(callback, new OAuthRequestAsync.ResponseConverter<OAuth1RequestToken>() {
+            @Override
+            public OAuth1RequestToken convert(Response response) throws IOException {
+                return getApi().getRequestTokenExtractor().extract(response.getBody());
+            }
+        });
+    }
+
+    protected void prepareRequestTokenRequest(AbstractRequest request) {
+        final OAuthConfig config = getConfig();
+        config.log("setting oauth_callback to " + config.getCallback());
+        request.addOAuthParameter(OAuthConstants.CALLBACK, config.getCallback());
+        addOAuthParams(request, "");
+        appendSignature(request);
+    }
+
     private void addOAuthParams(AbstractRequest request, String tokenSecret) {
         final OAuthConfig config = getConfig();
         request.addOAuthParameter(OAuthConstants.TIMESTAMP, api.getTimestampService().getTimestampInSeconds());
