unix/moduselect: Fix bug in poll.poll() scanning loop.

pfalcon · pfalcon · commit 19920e25f99d · 2015-11-28T17:34:46.000+02:00
diff --git a/unix/moduselect.c b/unix/moduselect.c
@@ -130,13 +130,12 @@ STATIC mp_obj_t poll_poll(uint n_args, const mp_obj_t *args) {
     mp_obj_list_t *ret_list = mp_obj_new_list(n_ready, NULL);
     int ret_i = 0;
     struct pollfd *entries = self->entries;
-    for (int i = 0; i < self->len; i++) {
+    for (int i = 0; i < self->len; i++, entries++) {
         if (entries->revents != 0) {
             mp_obj_tuple_t *t = mp_obj_new_tuple(2, NULL);
             t->items[0] = MP_OBJ_NEW_SMALL_INT(entries->fd);
             t->items[1] = MP_OBJ_NEW_SMALL_INT(entries->revents);
             ret_list->items[ret_i++] = t;
-            entries++;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -130,13 +130,12 @@ STATIC mp_obj_t poll_poll(uint n_args, const mp_obj_t *args) {`
`130`	`130`	`mp_obj_list_t *ret_list = mp_obj_new_list(n_ready, NULL);`
`131`	`131`	`int ret_i = 0;`
`132`	`132`	`struct pollfd *entries = self->entries;`
`133`		`- for (int i = 0; i < self->len; i++) {`
	`133`	`+ for (int i = 0; i < self->len; i++, entries++) {`
`134`	`134`	`if (entries->revents != 0) {`
`135`	`135`	`mp_obj_tuple_t *t = mp_obj_new_tuple(2, NULL);`
`136`	`136`	`t->items[0] = MP_OBJ_NEW_SMALL_INT(entries->fd);`
`137`	`137`	`t->items[1] = MP_OBJ_NEW_SMALL_INT(entries->revents);`
`138`	`138`	`ret_list->items[ret_i++] = t;`
`139`		`- entries++;`
`140`	`139`	`}`
`141`	`140`	`}`
`142`	`141`