Lint is not working for catching Namespace Indentation error

Hello, i found some error related to indentation and it seems worth it to solve.

In google style guide, there is the contents for namespace indentation
https://google.github.io/styleguide/cppguide.html#Namespace_Formatting
Specifying 'the contents of namespace are not indented'.

For example,

You can see there is indent inside in namespace scope.
This is not fit to google style guide.

This is the example of correct style refer to google style guide.

And as you can see,

lint is not catching!

I think it would be great that if this problem solved.
Can anyone give comments or feedback for this issue?

Thankyou!

There is a patch for this error, and i'm preparing for pull request.
If anyone interested, please check the pr!

Since the update to 2.0, I'm seeing the opposite. It's overly aggressive in complaining that I content within a namespace should not be indented even though it's not (a false positive). E.g.,

#include "gtest/gtest.h"

namespace MyNamespace {
namespace {

TEST(MyTest,
     SomeVeryLongTestNameSoThatClangFormatBreaksLinesAtEightyChars) {
  // Test body.
}

}  // namespace
}  // namespace MyNamespace

cpplint complains that the line starting with SomeVeryLong..., should not be indented.

@jiawen

@jiawen This is an old and fixed issue, and you're correct that we now have #293.

@jiawen This is an old and fixed issue, and you're correct that we now have #293.

Ha I must be blind. I thought I looked through all issues with namespace in the title. Anyway, thanks! Looks like you just fixed #293.

Navigation Menu

Repository navigation

Lint is not working for catching Namespace Indentation error #234

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Lint is not working for catching Namespace Indentation error #234

Description

Activity

Yujinmon commented on Nov 17, 2023

jiawen commented on Jan 29, 2025

aaronliu0130 commented on Jan 29, 2025

jiawen commented on Feb 2, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions