Skip to content

Commit c253552

Browse files
committed
fix cli tests after "Fix the build/endif_comment check."
1 parent 2647511 commit c253552

7 files changed

Lines changed: 242 additions & 6 deletions

File tree

cpplint_clitest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ def RunShellCommand(cmd, cwd='.'):
5353
stdout=stdout_target,
5454
stderr=stderr_target)
5555
out, err = proc.communicate()
56+
# print(err) # to get the output at time of test
5657
return (proc.returncode, out, err)
5758

5859

@@ -104,6 +105,7 @@ def checkAllInFolder(self, foldername, expectedDefs):
104105
self.assertEqual(count, expectedDefs)
105106

106107
def checkDef(self, path):
108+
# self.maxDiff = None # to see full diff
107109
with open(path, 'rb') as filehandle:
108110
datalines = filehandle.readlines()
109111
self.runAndCheck(os.path.dirname(path),

samples/boost-sample/headers_simple.def

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ src/tr1/c_policy.hpp:27: Weird number of spaces at line-start. Are you using a
2020
src/tr1/c_policy.hpp:28: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
2121
src/tr1/c_policy.hpp:30: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
2222
src/tr1/c_policy.hpp:32: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
23+
src/tr1/c_policy.hpp:33: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
2324
src/tr1/c_policy.hpp:34: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
2425
src/tr1/c_policy.hpp:35: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
2526
src/tr1/c_policy.hpp:36: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
@@ -46,6 +47,7 @@ src/tr1/c_policy.hpp:60: Weird number of spaces at line-start. Are you using a
4647
src/tr1/c_policy.hpp:61: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
4748
src/tr1/c_policy.hpp:63: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
4849
src/tr1/c_policy.hpp:65: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
50+
src/tr1/c_policy.hpp:66: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
4951
src/tr1/c_policy.hpp:67: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
5052
src/tr1/c_policy.hpp:68: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
5153
src/tr1/c_policy.hpp:69: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
@@ -67,5 +69,5 @@ src/tr1/c_policy.hpp:109: At least two spaces is best between code and comments
6769
src/tr1/c_policy.hpp:111: Missing space before { [whitespace/braces] [5]
6870
src/tr1/c_policy.hpp:131: Namespace should be terminated with "// namespace c_policies" [readability/namespace] [5]
6971
Done processing src/tr1/c_policy.hpp
70-
Total errors found: 66
72+
Total errors found: 68
7173

samples/boost-sample/simple.def

Lines changed: 103 additions & 1 deletion
Large diffs are not rendered by default.

samples/chromium-sample/simple.def

Lines changed: 96 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,116 @@
11
src/*
22
1
33
src/chrome_content_renderer_client.cc:113: Include the directory when naming .h files [build/include_subdir] [4]
4+
src/chrome_content_renderer_client.cc:118: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
5+
src/chrome_content_renderer_client.cc:127: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
6+
src/chrome_content_renderer_client.cc:131: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
7+
src/chrome_content_renderer_client.cc:136: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
8+
src/chrome_content_renderer_client.cc:143: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
9+
src/chrome_content_renderer_client.cc:147: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
10+
src/chrome_content_renderer_client.cc:152: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
11+
src/chrome_content_renderer_client.cc:156: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
12+
src/chrome_content_renderer_client.cc:199: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
13+
src/chrome_content_renderer_client.cc:240: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
14+
src/chrome_content_renderer_client.cc:272: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
15+
src/chrome_content_renderer_client.cc:279: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
16+
src/chrome_content_renderer_client.cc:312: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
17+
src/chrome_content_renderer_client.cc:319: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
18+
src/chrome_content_renderer_client.cc:322: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
19+
src/chrome_content_renderer_client.cc:339: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
20+
src/chrome_content_renderer_client.cc:350: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
21+
src/chrome_content_renderer_client.cc:354: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
22+
src/chrome_content_renderer_client.cc:359: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
23+
src/chrome_content_renderer_client.cc:364: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
24+
src/chrome_content_renderer_client.cc:371: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
25+
src/chrome_content_renderer_client.cc:402: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
26+
src/chrome_content_renderer_client.cc:407: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
27+
src/chrome_content_renderer_client.cc:417: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
28+
src/chrome_content_renderer_client.cc:432: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
29+
src/chrome_content_renderer_client.cc:460: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
30+
src/chrome_content_renderer_client.cc:471: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
31+
src/chrome_content_renderer_client.cc:475: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
32+
src/chrome_content_renderer_client.cc:479: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
33+
src/chrome_content_renderer_client.cc:483: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
34+
src/chrome_content_renderer_client.cc:523: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
35+
src/chrome_content_renderer_client.cc:529: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
36+
src/chrome_content_renderer_client.cc:532: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
37+
src/chrome_content_renderer_client.cc:566: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
38+
src/chrome_content_renderer_client.cc:752: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
39+
src/chrome_content_renderer_client.cc:817: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
40+
src/chrome_content_renderer_client.cc:1053: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
41+
src/chrome_content_renderer_client.cc:1062: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
42+
src/chrome_content_renderer_client.cc:1070: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
43+
src/chrome_content_renderer_client.cc:1133: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
444
src/chrome_content_renderer_client.cc:1156: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
545
src/chrome_content_renderer_client.cc:1161: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
46+
src/chrome_content_renderer_client.cc:1191: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
47+
src/chrome_content_renderer_client.cc:1209: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
48+
src/chrome_content_renderer_client.cc:1255: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
49+
src/chrome_content_renderer_client.cc:1269: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
50+
src/chrome_content_renderer_client.cc:1294: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
51+
src/chrome_content_renderer_client.cc:1306: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
52+
src/chrome_content_renderer_client.cc:1324: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
53+
src/chrome_content_renderer_client.cc:1337: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
54+
src/chrome_content_renderer_client.cc:1378: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
55+
src/chrome_content_renderer_client.cc:1387: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
56+
src/chrome_content_renderer_client.cc:1397: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
57+
src/chrome_content_renderer_client.cc:1406: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
58+
src/chrome_content_renderer_client.cc:1418: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
659
src/chrome_content_renderer_client.cc:5: samples/chromium-sample/src/chrome_content_renderer_client.cc should include its header file samples/chromium-sample/src/chrome_content_renderer_client.h [build/include] [5]
760
Done processing src/chrome_content_renderer_client.cc
861
src/chrome_content_renderer_client.h:5: #ifndef header guard has wrong style, please use: SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_ [build/header_guard] [5]
962
src/chrome_content_renderer_client.h:225: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_" [build/header_guard] [5]
63+
src/chrome_content_renderer_client.h:26: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
64+
src/chrome_content_renderer_client.h:31: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
65+
src/chrome_content_renderer_client.h:71: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
1066
src/chrome_content_renderer_client.h:115: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
1167
src/chrome_content_renderer_client.h:117: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
68+
src/chrome_content_renderer_client.h:164: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
69+
src/chrome_content_renderer_client.h:172: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
70+
src/chrome_content_renderer_client.h:177: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
71+
src/chrome_content_renderer_client.h:199: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
72+
src/chrome_content_renderer_client.h:209: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
73+
src/chrome_content_renderer_client.h:215: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
74+
src/chrome_content_renderer_client.h:218: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
75+
src/chrome_content_renderer_client.h:222: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
1276
Done processing src/chrome_content_renderer_client.h
77+
src/io_thread.cc:112: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
78+
src/io_thread.cc:116: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
79+
src/io_thread.cc:123: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
80+
src/io_thread.cc:128: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
81+
src/io_thread.cc:133: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
82+
src/io_thread.cc:198: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
83+
src/io_thread.cc:220: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
84+
src/io_thread.cc:229: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
85+
src/io_thread.cc:237: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
86+
src/io_thread.cc:270: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
87+
src/io_thread.cc:435: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
88+
src/io_thread.cc:467: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
89+
src/io_thread.cc:470: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
90+
src/io_thread.cc:576: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
91+
src/io_thread.cc:609: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
92+
src/io_thread.cc:614: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
93+
src/io_thread.cc:641: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
94+
src/io_thread.cc:659: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
95+
src/io_thread.cc:682: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
96+
src/io_thread.cc:852: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
97+
src/io_thread.cc:874: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
98+
src/io_thread.cc:882: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
99+
src/io_thread.cc:1127: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
100+
src/io_thread.cc:1147: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
13101
src/io_thread.cc:1148: Closing ) should be moved to the previous line [whitespace/parens] [2]
102+
src/io_thread.cc:1155: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
14103
src/io_thread.cc:1547: Missing space around colon in range-based for loop [whitespace/forcolon] [2]
104+
src/io_thread.cc:1749: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
15105
src/io_thread.cc:5: samples/chromium-sample/src/io_thread.cc should include its header file samples/chromium-sample/src/io_thread.h [build/include] [5]
16106
Done processing src/io_thread.cc
17107
src/io_thread.h:5: #ifndef header guard has wrong style, please use: SAMPLES_CHROMIUM_SAMPLE_SRC_IO_THREAD_H_ [build/header_guard] [5]
18108
src/io_thread.h:565: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_IO_THREAD_H_" [build/header_guard] [5]
109+
src/io_thread.h:177: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
110+
src/io_thread.h:467: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
111+
src/io_thread.h:490: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
112+
src/io_thread.h:526: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
113+
src/io_thread.h:532: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
19114
Done processing src/io_thread.h
20-
Total errors found: 13
115+
Total errors found: 108
21116

samples/codelite-sample/simple.def

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ src/pptable.cpp:170: Tab found; better to use spaces [whitespace/tab] [1]
164164
src/pptable.cpp:170: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
165165
src/pptable.cpp:170: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
166166
src/pptable.cpp:171: Tab found; better to use spaces [whitespace/tab] [1]
167+
src/pptable.cpp:172: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
167168
src/pptable.cpp:173: Tab found; better to use spaces [whitespace/tab] [1]
168169
src/pptable.cpp:177: { should almost always be at the end of the previous line [whitespace/braces] [4]
169170
src/pptable.cpp:179: Tab found; better to use spaces [whitespace/tab] [1]
@@ -183,6 +184,7 @@ src/pptable.cpp:191: Tab found; better to use spaces [whitespace/tab] [1]
183184
src/pptable.cpp:192: Tab found; better to use spaces [whitespace/tab] [1]
184185
src/pptable.cpp:192: Lines should be <= 80 characters long [whitespace/line_length] [2]
185186
src/pptable.cpp:193: Tab found; better to use spaces [whitespace/tab] [1]
187+
src/pptable.cpp:194: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
186188
src/pptable.cpp:198: { should almost always be at the end of the previous line [whitespace/braces] [4]
187189
src/pptable.cpp:199: Tab found; better to use spaces [whitespace/tab] [1]
188190
src/pptable.cpp:200: Tab found; better to use spaces [whitespace/tab] [1]
@@ -605,6 +607,8 @@ src/pptable.h:1: #ifndef header guard has wrong style, please use: SAMPLES_CODE
605607
src/pptable.h:131: #endif line should be "#endif // SAMPLES_CODELITE_SAMPLE_SRC_PPTABLE_H_" [build/header_guard] [5]
606608
src/pptable.h:6: Found C system header after C++ system header. Should be: pptable.h, c system, c++ system, other. [build/include_order] [4]
607609
src/pptable.h:19: At least two spaces is best between code and comments [whitespace/comments] [2]
610+
src/pptable.h:21: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
611+
src/pptable.h:23: Uncommented text after #endif is non-standard. Use a comment. [build/endif_comment] [5]
608612
src/pptable.h:27: Tab found; better to use spaces [whitespace/tab] [1]
609613
src/pptable.h:28: Tab found; better to use spaces [whitespace/tab] [1]
610614
src/pptable.h:29: Tab found; better to use spaces [whitespace/tab] [1]
@@ -682,5 +686,5 @@ src/pptable.h:128: Tab found; better to use spaces [whitespace/tab] [1]
682686
src/pptable.h:129: Tab found; better to use spaces [whitespace/tab] [1]
683687
src/pptable.h:131: At least two spaces is best between code and comments [whitespace/comments] [2]
684688
Done processing src/pptable.h
685-
Total errors found: 680
689+
Total errors found: 684
686690

0 commit comments

Comments
 (0)