Skip to content

Commit 30e502e

Browse files
aaronliu0130aaronliu0130
committed
update samples to match PR
1 parent b5ddf55 commit 30e502e

File tree

7 files changed

+34
-6
lines changed

7 files changed

+34
-6
lines changed

‎samples/chromium-sample/simple.def‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,26 @@ Done processing src/chrome_content_renderer_client.cc
55
Done processing src/chrome_content_renderer_client.h
66
Done processing src/io_thread.cc
77
Done processing src/io_thread.h
8-
Total errors found: 13
8+
Total errors found: 21
99

1010
src/chrome_content_renderer_client.cc:113: Include the directory when naming header files [build/include_subdir] [4]
1111
src/chrome_content_renderer_client.cc:1156: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
1212
src/chrome_content_renderer_client.cc:1161: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
13+
src/chrome_content_renderer_client.cc:1203: Add #include <set> for set<> [build/include_what_you_use] [4]
14+
src/chrome_content_renderer_client.cc:1245: Add #include <vector> for vector<> [build/include_what_you_use] [4]
15+
src/chrome_content_renderer_client.cc:1359: Add #include <map> for map<> [build/include_what_you_use] [4]
16+
src/chrome_content_renderer_client.cc:1366: Add #include <string> for string [build/include_what_you_use] [4]
1317
src/chrome_content_renderer_client.cc:5: samples/chromium-sample/src/chrome_content_renderer_client.cc should include its header file samples/chromium-sample/src/chrome_content_renderer_client.h [build/include] [5]
1418
src/chrome_content_renderer_client.h:5: #ifndef header guard has wrong style, please use: SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_ [build/header_guard] [5]
1519
src/chrome_content_renderer_client.h:225: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_CHROME_CONTENT_RENDERER_CLIENT_H_" [build/header_guard] [5]
1620
src/chrome_content_renderer_client.h:115: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
1721
src/chrome_content_renderer_client.h:117: Use int16/int64/etc, rather than the C type long [runtime/int] [4]
1822
src/io_thread.cc:1148: Closing ) should be moved to the previous line [whitespace/parens] [2]
1923
src/io_thread.cc:1547: Missing space around colon in range-based for loop [whitespace/forcolon] [2]
24+
src/io_thread.cc:651: Add #include <map> for map<> [build/include_what_you_use] [4]
25+
src/io_thread.cc:1546: Add #include <unordered_set> for unordered_set<> [build/include_what_you_use] [4]
26+
src/io_thread.cc:1609: Add #include <string> for string [build/include_what_you_use] [4]
27+
src/io_thread.cc:1731: Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
2028
src/io_thread.cc:5: samples/chromium-sample/src/io_thread.cc should include its header file samples/chromium-sample/src/io_thread.h [build/include] [5]
2129
src/io_thread.h:5: #ifndef header guard has wrong style, please use: SAMPLES_CHROMIUM_SAMPLE_SRC_IO_THREAD_H_ [build/header_guard] [5]
2230
src/io_thread.h:565: #endif line should be "#endif // SAMPLES_CHROMIUM_SAMPLE_SRC_IO_THREAD_H_" [build/header_guard] [5]

‎samples/codelite-sample/simple.def‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ src/*
33
4
44
Done processing src/pptable.cpp
55
Done processing src/pptable.h
6-
Total errors found: 681
6+
Total errors found: 682
77

88
src/pptable.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
99
src/pptable.cpp:1: Include the directory when naming header files [build/include_subdir] [4]
@@ -605,6 +605,7 @@ src/pptable.cpp:660: Tab found; better to use spaces [whitespace/tab] [1]
605605
src/pptable.cpp:661: Tab found; better to use spaces [whitespace/tab] [1]
606606
src/pptable.cpp:662: Tab found; better to use spaces [whitespace/tab] [1]
607607
src/pptable.cpp:663: Tab found; better to use spaces [whitespace/tab] [1]
608+
src/pptable.cpp:602: Add #include <cstdio> for sprintf [build/include_what_you_use] [4]
608609
src/pptable.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
609610
src/pptable.h:1: #ifndef header guard has wrong style, please use: SAMPLES_CODELITE_SAMPLE_SRC_PPTABLE_H_ [build/header_guard] [5]
610611
src/pptable.h:131: #endif line should be "#endif // SAMPLES_CODELITE_SAMPLE_SRC_PPTABLE_H_" [build/header_guard] [5]

‎samples/protobuf-sample/simple.def‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ src/*
44
Done processing src/descriptor.pb.cc
55
Done processing src/descriptor.pb.h
66
Done processing src/descriptor_unittest.cc
7-
Total errors found: 2643
7+
Total errors found: 2646
88

99
src/descriptor.pb.cc:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
1010
src/descriptor.pb.cc:9: Found C system header after C++ system header. Should be: descriptor.pb.h, c system, c++ system, other. [build/include_order] [4]
@@ -1626,6 +1626,8 @@ src/descriptor.pb.cc:15142: Lines should be <= 80 characters long [whitespace/
16261626
src/descriptor.pb.cc:15146: Lines should be <= 80 characters long [whitespace/line_length] [2]
16271627
src/descriptor.pb.cc:15150: Lines should be <= 80 characters long [whitespace/line_length] [2]
16281628
src/descriptor.pb.cc:15155: Lines should be <= 80 characters long [whitespace/line_length] [2]
1629+
src/descriptor.pb.cc:14981: Add #include <utility> for swap [build/include_what_you_use] [4]
1630+
src/descriptor.pb.cc:15069: Add #include <string> for string [build/include_what_you_use] [4]
16291631
src/descriptor.pb.cc:5: samples/protobuf-sample/src/descriptor.pb.cc should include its header file samples/protobuf-sample/src/descriptor.pb.h [build/include] [5]
16301632
src/descriptor.pb.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
16311633
src/descriptor.pb.h:4: #ifndef header guard has wrong style, please use: SAMPLES_PROTOBUF_SAMPLE_SRC_DESCRIPTOR_PB_H_ [build/header_guard] [5]
@@ -2649,4 +2651,5 @@ src/descriptor_unittest.cc:5125: Closing ) should be moved to the previous line
26492651
src/descriptor_unittest.cc:5929: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
26502652
src/descriptor_unittest.cc:5968: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
26512653
src/descriptor_unittest.cc:6486: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
2654+
src/descriptor_unittest.cc:6437: Add #include <string> for string [build/include_what_you_use] [4]
26522655

‎samples/silly-sample/includeorder_cfirst.def‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
1
33
3
44
Done processing src/sillycode.cpp
5-
Total errors found: 106
5+
Total errors found: 111
66

77
src/sillycode.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
88
src/sillycode.cpp:8: public: should be indented +1 space inside class Date [whitespace/indent] [3]
@@ -110,4 +110,9 @@ src/sillycode.cpp:257: Tab found; better to use spaces [whitespace/tab] [1]
110110
src/sillycode.cpp:257: At least two spaces is best between code and comments [whitespace/comments] [2]
111111
src/sillycode.cpp:260: Empty loop bodies should use {} or continue [whitespace/empty_loop_body] [5]
112112
src/sillycode.cpp:260: At least two spaces is best between code and comments [whitespace/comments] [2]
113+
src/sillycode.cpp:126: Add #include <utility> for swap [build/include_what_you_use] [4]
114+
src/sillycode.cpp:168: Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
115+
src/sillycode.cpp:224: Add #include <limits> for numeric_limits<> [build/include_what_you_use] [4]
116+
src/sillycode.cpp:237: Add #include <string> for string [build/include_what_you_use] [4]
117+
src/sillycode.cpp:244: Add #include <iostream> for cout [build/include_what_you_use] [4]
113118

‎samples/silly-sample/sed.def‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,9 @@ sed -i '208s/\([^ ]\){/\1 {/' src/sillycode.cpp # Missing space before { [white
109109
# src/sillycode.cpp:257: "At least two spaces is best between code and comments" [whitespace/comments] [2]
110110
# src/sillycode.cpp:260: "Empty loop bodies should use {} or continue" [whitespace/empty_loop_body] [5]
111111
# src/sillycode.cpp:260: "At least two spaces is best between code and comments" [whitespace/comments] [2]
112+
# src/sillycode.cpp:126: "Add #include <utility> for swap" [build/include_what_you_use] [4]
113+
# src/sillycode.cpp:168: "Add #include <memory> for unique_ptr<>" [build/include_what_you_use] [4]
114+
# src/sillycode.cpp:224: "Add #include <limits> for numeric_limits<>" [build/include_what_you_use] [4]
115+
# src/sillycode.cpp:237: "Add #include <string> for string" [build/include_what_you_use] [4]
116+
# src/sillycode.cpp:244: "Add #include <iostream> for cout" [build/include_what_you_use] [4]
112117

‎samples/silly-sample/simple.def‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ src/*.cpp
22
1
33
3
44
Done processing src/sillycode.cpp
5-
Total errors found: 107
5+
Total errors found: 112
66

77
src/sillycode.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
88
src/sillycode.cpp:3: Found C system header after C++ system header. Should be: sillycode.h, c system, c++ system, other. [build/include_order] [4]
@@ -111,4 +111,9 @@ src/sillycode.cpp:257: Tab found; better to use spaces [whitespace/tab] [1]
111111
src/sillycode.cpp:257: At least two spaces is best between code and comments [whitespace/comments] [2]
112112
src/sillycode.cpp:260: Empty loop bodies should use {} or continue [whitespace/empty_loop_body] [5]
113113
src/sillycode.cpp:260: At least two spaces is best between code and comments [whitespace/comments] [2]
114+
src/sillycode.cpp:126: Add #include <utility> for swap [build/include_what_you_use] [4]
115+
src/sillycode.cpp:168: Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
116+
src/sillycode.cpp:224: Add #include <limits> for numeric_limits<> [build/include_what_you_use] [4]
117+
src/sillycode.cpp:237: Add #include <string> for string [build/include_what_you_use] [4]
118+
src/sillycode.cpp:244: Add #include <iostream> for cout [build/include_what_you_use] [4]
114119

‎samples/vlc-sample/simple.def‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ src/*
44
Done processing src/libvlc.c
55
Done processing src/libvlc.h
66
Done processing src/missing.c
7-
Total errors found: 601
7+
Total errors found: 602
88

99
src/libvlc.c:41: Found C system header after other header. Should be: libvlc.h, c system, c++ system, other. [build/include_order] [4]
1010
src/libvlc.c:47: Found C system header after other header. Should be: libvlc.h, c system, c++ system, other. [build/include_order] [4]
@@ -367,6 +367,7 @@ src/libvlc.c:627: Missing space before ( in if( [whitespace/parens] [5]
367367
src/libvlc.c:629: Extra space after ( in function call [whitespace/parens] [4]
368368
src/libvlc.c:629: Extra space before ) [whitespace/parens] [2]
369369
src/libvlc.c:640: { should almost always be at the end of the previous line [whitespace/braces] [4]
370+
src/libvlc.c:223: Add #include <cstdio> for fclose [build/include_what_you_use] [4]
370371
src/libvlc.h:0: No #ifndef header guard found, suggested CPP variable is: SAMPLES_VLC_SAMPLE_SRC_LIBVLC_H_ [build/header_guard] [5]
371372
src/libvlc.h:34: Extra space before ( in function call [whitespace/parens] [4]
372373
src/libvlc.h:35: Extra space before ( in function call [whitespace/parens] [4]

0 commit comments

Comments
 (0)