- don't throw if SSL client unexpectedly closes connection as this seems to be the normal behavior of web browsers (seen with Chrome and IE)

obiltschnig · obiltschnig · commit 84adc737d49f · 2014-10-02T14:58:45.000+02:00
diff --git a/NetSSL_OpenSSL/src/SecureSocketImpl.cpp b/NetSSL_OpenSSL/src/SecureSocketImpl.cpp
@@ -433,7 +433,15 @@ int SecureSocketImpl::handleError(int rc)
 			long lastError = ERR_get_error();
 			if (lastError == 0)
 			{
-				if (rc == 0 || rc == -1)
+				if (rc == 0)
+				{
+					// Most web browsers do this, don't report an error
+					if (_pContext->isForServerUse())
+						return 0;
+					else
+						throw SSLConnectionUnexpectedlyClosedException();
+				}
+				else if (rc == -1)
 				{
 					throw SSLConnectionUnexpectedlyClosedException();
 				}

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,15 @@ int SecureSocketImpl::handleError(int rc)`
`433`	`433`	`long lastError = ERR_get_error();`
`434`	`434`	`if (lastError == 0)`
`435`	`435`	`{`
`436`		`- if (rc == 0 \|\| rc == -1)`
	`436`	`+ if (rc == 0)`
	`437`	`+ {`
	`438`	`+ // Most web browsers do this, don't report an error`
	`439`	`+ if (_pContext->isForServerUse())`
	`440`	`+ return 0;`
	`441`	`+ else`
	`442`	`+ throw SSLConnectionUnexpectedlyClosedException();`
	`443`	`+ }`
	`444`	`+ else if (rc == -1)`
`437`	`445`	`{`
`438`	`446`	`throw SSLConnectionUnexpectedlyClosedException();`
`439`	`447`	`}`