Close listening socket before stopping running connections

kblaschke · kblaschke · commit 6c37cad87d4a · 2014-05-02T13:54:42.000+02:00
If sending the serverStopped event to currently active connections
happens before actually closing the server socket, new connections will
be accepted in between, which in turn will stay open and prevent the
HTTP server from stopping completely.
diff --git a/Net/src/HTTPServer.cpp b/Net/src/HTTPServer.cpp
@@ -70,8 +70,8 @@ HTTPServer::~HTTPServer()
 
 void HTTPServer::stopAll(bool abortCurrent)
 {
-	_pFactory->serverStopped(this, abortCurrent);
 	stop();
+	_pFactory->serverStopped(this, abortCurrent);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,8 @@ HTTPServer::~HTTPServer()`
`70`	`70`
`71`	`71`	`void HTTPServer::stopAll(bool abortCurrent)`
`72`	`72`	`{`
`73`		`- _pFactory->serverStopped(this, abortCurrent);`
`74`	`73`	`stop();`
	`74`	`+ _pFactory->serverStopped(this, abortCurrent);`
`75`	`75`	`}`
`76`	`76`
`77`	`77`