Fixed setting of MYSQL_BIND is_unsigned value.

simon-graham · simon-graham · commit 58121249c7ce · 2013-12-19T18:00:19.000Z
diff --git a/Data/MySQL/include/Poco/Data/MySQL/Extractor.h b/Data/MySQL/include/Poco/Data/MySQL/Extractor.h
@@ -98,7 +98,6 @@ class MySQL_API Extractor: public Poco::Data::AbstractExtractor
 	virtual bool extract(std::size_t pos, long& val);
 		/// Extracts a long. Returns false if null was received.
 
-
 	virtual bool extract(std::size_t pos, unsigned long& val);
 		/// Extracts an unsigned long. Returns false if null was received.
 #endif
@@ -342,7 +341,7 @@ class MySQL_API Extractor: public Poco::Data::AbstractExtractor
 	
 private:
 
-	bool realExtractFixed(std::size_t pos, enum_field_types type, void* buffer, std::size_t length = 0, bool isUnsigned = false);
+	bool realExtractFixed(std::size_t pos, enum_field_types type, void* buffer, bool isUnsigned = false);
 
 	// Prevent VC8 warning "operator= could not be generated"
 	Extractor& operator=(const Extractor&);
diff --git a/Data/MySQL/src/Extractor.cpp b/Data/MySQL/src/Extractor.cpp
@@ -257,15 +257,14 @@ void Extractor::reset()
 }
 
 
-bool Extractor::realExtractFixed(std::size_t pos, enum_field_types type, void* buffer, std::size_t length, bool isUnsigned)
+bool Extractor::realExtractFixed(std::size_t pos, enum_field_types type, void* buffer, bool isUnsigned)
 {
 	MYSQL_BIND bind = {0};
 	my_bool isNull = 0;
 
 	bind.is_null	   = &isNull;
 	bind.buffer_type   = type;
 	bind.buffer		= buffer;
-	bind.buffer_length = static_cast<unsigned long>(length);
 	bind.is_unsigned   = isUnsigned;
 	
 	if (!_stmt.fetchColumn(pos, &bind))

Original file line number	Diff line number	Diff line change
`@@ -257,15 +257,14 @@ void Extractor::reset()`
`257`	`257`	`}`
`258`	`258`
`259`	`259`
`260`		`-bool Extractor::realExtractFixed(std::size_t pos, enum_field_types type, void* buffer, std::size_t length, bool isUnsigned)`
	`260`	`+bool Extractor::realExtractFixed(std::size_t pos, enum_field_types type, void* buffer, bool isUnsigned)`
`261`	`261`	`{`
`262`	`262`	`MYSQL_BIND bind = {0};`
`263`	`263`	`my_bool isNull = 0;`
`264`	`264`
`265`	`265`	`bind.is_null = &isNull;`
`266`	`266`	`bind.buffer_type = type;`
`267`	`267`	`bind.buffer = buffer;`
`268`		`- bind.buffer_length = static_cast<unsigned long>(length);`
`269`	`268`	`bind.is_unsigned = isUnsigned;`
`270`	`269`
`271`	`270`	`if (!_stmt.fetchColumn(pos, &bind))`