GH 109: Bug in SMTPClientSession::loginUsingPlain

aleks-f · aleks-f · commit 4e3ff72803a3 · 2013-02-27T12:41:17.000-06:00
- fixed GH# 109: Bug in Poco::Net::SMTPClientSession::loginUsingPlain
diff --git a/CHANGELOG b/CHANGELOG
@@ -15,6 +15,7 @@ Release 1.5.2 (2013-03-??)
 - fixed GH #110: WebSocket accept() fails when Connection header contains multiple tokens
 - fixed GH# 71: WebSocket and broken Timeouts (POCO_BROKEN_TIMEOUTS)
 - fixed a warning in Poco/Crypto/OpenSSLInitializer.h
+- fixed GH# 109: Bug in Poco::Net::SMTPClientSession::loginUsingPlain
 
 Release 1.5.1 (2013-01-11)
 ==========================
diff --git a/Net/src/SMTPClientSession.cpp b/Net/src/SMTPClientSession.cpp
@@ -230,7 +230,7 @@ void SMTPClientSession::loginUsingPlain(const std::string& username, const std::
 {
 	std::ostringstream credentialsBase64;
 	Base64Encoder credentialsEncoder(credentialsBase64);
-	credentialsEncoder << username << '\0' << password;
+	credentialsEncoder << '\0' << username << '\0' << password;
 	credentialsEncoder.close();
 
 	std::string response;

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ void SMTPClientSession::loginUsingPlain(const std::string& username, const std::`
`230`	`230`	`{`
`231`	`231`	`std::ostringstream credentialsBase64;`
`232`	`232`	`Base64Encoder credentialsEncoder(credentialsBase64);`
`233`		`- credentialsEncoder << username << '\0' << password;`
	`233`	`+ credentialsEncoder << '\0' << username << '\0' << password;`
`234`	`234`	`credentialsEncoder.close();`
`235`	`235`
`236`	`236`	`std::string response;`