Fix potential NULL pointer dereferencing in ast module

tiran · tiran · commit 7d4cd2fb417c · 2013-07-24T21:02:50.000+02:00
CID 719690
diff --git a/Python/ast.c b/Python/ast.c
@@ -528,11 +528,11 @@ init_normalization(struct compiling *c)
     if (!c->c_normalize)
         return 0;
     c->c_normalize_args = Py_BuildValue("(sN)", "NFKC", Py_None);
-    PyTuple_SET_ITEM(c->c_normalize_args, 1, NULL);
     if (!c->c_normalize_args) {
         Py_CLEAR(c->c_normalize);
         return 0;
     }
+    PyTuple_SET_ITEM(c->c_normalize_args, 1, NULL);
     return 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -528,11 +528,11 @@ init_normalization(struct compiling *c)`
`528`	`528`	`if (!c->c_normalize)`
`529`	`529`	`return 0;`
`530`	`530`	`c->c_normalize_args = Py_BuildValue("(sN)", "NFKC", Py_None);`
`531`		`- PyTuple_SET_ITEM(c->c_normalize_args, 1, NULL);`
`532`	`531`	`if (!c->c_normalize_args) {`
`533`	`532`	`Py_CLEAR(c->c_normalize);`
`534`	`533`	`return 0;`
`535`	`534`	`}`
	`535`	`+ PyTuple_SET_ITEM(c->c_normalize_args, 1, NULL);`
`536`	`536`	`return 1;`
`537`	`537`	`}`
`538`	`538`