Fixed false positive cppcheck-opensource#5466

PKEuS · PKEuS · commit b8918906e645 · 2014-08-31T19:46:30.000+02:00
diff --git a/lib/checkunusedvar.cpp b/lib/checkunusedvar.cpp
@@ -1056,8 +1056,10 @@ void CheckUnusedVar::checkFunctionVariableUsage_iterateScopes(const Scope* const
         else if (tok->isAssignmentOp()) {
             for (const Token *tok2 = tok->next(); tok2 && tok2->str() != ";"; tok2 = tok2->next()) {
                 if (tok2->varId()) {
-                    if (tok2->next()->isAssignmentOp())
+                    if (tok2->strAt(1) == "=")
                         variables.write(tok2->varId(), tok);
+                    else if (tok2->next()->isAssignmentOp())
+                        variables.use(tok2->varId(), tok);
                     else
                         variables.read(tok2->varId(), tok);
                 }
diff --git a/test/testunusedvar.cpp b/test/testunusedvar.cpp
@@ -156,6 +156,8 @@ class TestUnusedVar : public TestFixture {
         TEST_CASE(localvarNULL);     // #4203 - Setting NULL value is not redundant - it is safe
         TEST_CASE(localvarUnusedGoto);    // #4447, #4558 goto
 
+        TEST_CASE(chainedAssignment); // #5466
+
         TEST_CASE(crash1);
         TEST_CASE(crash2);
         TEST_CASE(usingNamespace);     // #4585
@@ -3773,6 +3775,16 @@ class TestUnusedVar : public TestFixture {
         ASSERT_EQUALS("", errout.str());
     }
 
+    void chainedAssignment() {
+        // #5466
+        functionVariableUsage("void NotUsed(double* pdD, int n) {\n"
+                              "    double sum = 0.0;\n"
+                              "    for (int i = 0; i<n; ++i)\n"
+                              "        pdD[i] = (sum += pdD[i]);\n"
+                              "}");
+        ASSERT_EQUALS("", errout.str());
+    }
+
     void crash1() {
         functionVariableUsage("SAL_WNODEPRECATED_DECLARATIONS_PUSH\n"
                               "void convertToTokenArray() {\n"
