Fixed cppcheck-opensource#2428 (false alarm with code containing a throw clause)

Daniel Marjamäki · Daniel Marjamäki · commit 14cbaebfe2bf · 2011-01-07T20:45:33.000+01:00
diff --git a/lib/checkexceptionsafety.cpp b/lib/checkexceptionsafety.cpp
@@ -106,7 +106,7 @@ void CheckExceptionSafety::deallocThrow()
             bool globalVar = false;
             for (const Token *tok2 = _tokenizer->tokens(); tok2; tok2 = tok2->next())
             {
-                if (tok->varId() == varid)
+                if (tok2->varId() == varid)
                 {
                     globalVar = true;
                     break;
diff --git a/test/testexceptionsafety.cpp b/test/testexceptionsafety.cpp
@@ -35,7 +35,8 @@ class TestExceptionSafety : public TestFixture
     void run()
     {
         TEST_CASE(destructors);
-        TEST_CASE(deallocThrow);
+        TEST_CASE(deallocThrow1);
+        TEST_CASE(deallocThrow2);
     }
 
     void check(const std::string &code)
@@ -66,7 +67,7 @@ class TestExceptionSafety : public TestFixture
         ASSERT_EQUALS("[test.cpp:3]: (error) Throwing exception in destructor\n", errout.str());
     }
 
-    void deallocThrow()
+    void deallocThrow1()
     {
         check("int * p;\n"
               "void f(int x)\n"
@@ -78,6 +79,17 @@ class TestExceptionSafety : public TestFixture
               "}\n");
         ASSERT_EQUALS("[test.cpp:6]: (error) Throwing exception in invalid state, p points at deallocated memory\n", errout.str());
     }
+
+    void deallocThrow2()
+    {
+        check("void f() {\n"
+              "    int* p = 0;\n"
+              "    delete p;\n"
+              "    throw 1;\n"
+              "    p = new int;\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
+    }
 };
 
 REGISTER_TEST(TestExceptionSafety)

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ void CheckExceptionSafety::deallocThrow()`
`106`	`106`	`bool globalVar = false;`
`107`	`107`	`for (const Token *tok2 = _tokenizer->tokens(); tok2; tok2 = tok2->next())`
`108`	`108`	`{`
`109`		`- if (tok->varId() == varid)`
	`109`	`+ if (tok2->varId() == varid)`
`110`	`110`	`{`
`111`	`111`	`globalVar = true;`
`112`	`112`	`break;`