You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The timeout in the bisection is based on the run time of a good revision times two - matching the daca time regression report. But if the package runs very long the timeout might be too big.
Example (short-running):
If an analysis finishes very fast it might not exceed the timeout but might still show a sizable regression. For that case a run time factor threshold was introduced so be able catch differences which cannot be properly captured in an integer value.
Example (long-running):
If an analysis takes 30 seconds it requires 60 seconds to hit the timeout. But an increase in 5 or 10 seconds is already sizable. For that case a run time difference threshold has been introduced.
These changes also help with cases where the increase is incremental over various commits and not absolute caused by a single one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these improvements help with bisecting performance issues in long/short-running cases