From f48d5ac1fbc00da4ada2e459a91089fb349ca991 Mon Sep 17 00:00:00 2001 From: Paul Date: Wed, 6 Apr 2022 16:23:31 -0500 Subject: [PATCH 1/2] Fix todo test that was using wrong function --- test/testautovariables.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/testautovariables.cpp b/test/testautovariables.cpp index 7c206213ea8..c55174f8677 100644 --- a/test/testautovariables.cpp +++ b/test/testautovariables.cpp @@ -2318,18 +2318,18 @@ class TestAutoVariables : public TestFixture { ASSERT_EQUALS("[test.cpp:3] -> [test.cpp:3]: (error) Returning iterator that will be invalid when returning.\n", errout.str()); - check("std::vector f();\n" + check("std::vector g();\n" "auto f() {\n" " auto it = g().begin();\n" " return it;\n" "}"); - TODO_ASSERT_EQUALS("error", "", errout.str()); + ASSERT_EQUALS("[test.cpp:3] -> [test.cpp:4]: (error) Returning iterator that will be invalid when returning.\n", errout.str()); - check("std::vector f();\n" + check("std::vector g();\n" "int& f() {\n" " return *g().begin();\n" "}"); - TODO_ASSERT_EQUALS("error", "", errout.str()); + ASSERT_EQUALS("[test.cpp:3] -> [test.cpp:3]: (error) Reference to temporary returned.\n", errout.str()); check("struct A {\n" " std::vector v;\n" From f913e2eef04b7bc5f9de8c475bbe3da4163b21a0 Mon Sep 17 00:00:00 2001 From: Paul Date: Wed, 6 Apr 2022 16:34:17 -0500 Subject: [PATCH 2/2] Format --- test/testautovariables.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/testautovariables.cpp b/test/testautovariables.cpp index c55174f8677..5f3cbb72899 100644 --- a/test/testautovariables.cpp +++ b/test/testautovariables.cpp @@ -2323,7 +2323,8 @@ class TestAutoVariables : public TestFixture { " auto it = g().begin();\n" " return it;\n" "}"); - ASSERT_EQUALS("[test.cpp:3] -> [test.cpp:4]: (error) Returning iterator that will be invalid when returning.\n", errout.str()); + ASSERT_EQUALS("[test.cpp:3] -> [test.cpp:4]: (error) Returning iterator that will be invalid when returning.\n", + errout.str()); check("std::vector g();\n" "int& f() {\n"