GUI: Don't show error when no application added.

kimmov · kimmov · commit dcfc7aa3f00a · 2011-04-04T11:16:53.000+03:00
I earlier added a check for missing (editor) application command
line parameters. If parameters are missing at GUI startup an
message is shown to user to check the settings. Unfortunately
my check was incomplete and it also triggered when there was no
applications defined. Which happens when user starts GUI for a
first time.

Fix the check so that user is only informed in case the parameters
are missing and name + path are set.
diff --git a/gui/applicationlist.cpp b/gui/applicationlist.cpp
@@ -50,7 +50,7 @@ bool ApplicationList::LoadSettings(QSettings *programSettings)
     // Params will be empty first time starting with the new setting.
     // Return false and inform user about problem with application settings.
     bool succeeded = true;
-    if (params.empty())
+    if (!names.empty() && !paths.empty() && params.empty())
     {
         for (int i = 0; i < paths.length(); i++)
             params << "";

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ bool ApplicationList::LoadSettings(QSettings *programSettings)`
`50`	`50`	`// Params will be empty first time starting with the new setting.`
`51`	`51`	`// Return false and inform user about problem with application settings.`
`52`	`52`	`bool succeeded = true;`
`53`		`- if (params.empty())`
	`53`	`+ if (!names.empty() && !paths.empty() && params.empty())`
`54`	`54`	`{`
`55`	`55`	`for (int i = 0; i < paths.length(); i++)`
`56`	`56`	`params << "";`