Use astIsPointer to avoid crashes

danmar · danmar · commit bcc7c5cd50bd · 2020-10-22T06:55:48.000+02:00
diff --git a/lib/checkcondition.cpp b/lib/checkcondition.cpp
@@ -469,7 +469,7 @@ void CheckCondition::duplicateCondition()
                 }
             }
             if (tok3->varId() > 0 &&
-                isVariableChanged(scope.classDef->next(), cond2, tok3->valueType()->pointer, tok3->varId(), false, mSettings, mTokenizer->isCPP())) {
+                isVariableChanged(scope.classDef->next(), cond2, astIsPointer(tok3), tok3->varId(), false, mSettings, mTokenizer->isCPP())) {
                 modified = true;
                 return ChildrenToVisit::done;
             }

Original file line number	Diff line number	Diff line change
`@@ -469,7 +469,7 @@ void CheckCondition::duplicateCondition()`
`469`	`469`	`}`
`470`	`470`	`}`
`471`	`471`	`if (tok3->varId() > 0 &&`
`472`		`- isVariableChanged(scope.classDef->next(), cond2, tok3->valueType()->pointer, tok3->varId(), false, mSettings, mTokenizer->isCPP())) {`
	`472`	`+ isVariableChanged(scope.classDef->next(), cond2, astIsPointer(tok3), tok3->varId(), false, mSettings, mTokenizer->isCPP())) {`
`473`	`473`	`modified = true;`
`474`	`474`	`return ChildrenToVisit::done;`
`475`	`475`	`}`