Fix #14973 FP assertWithSideEffect with function pointer comparison (#8792)

chrchr-github · web-flow · commit 2d75160cada4 · 2026-08-14T09:28:22.000+02:00
diff --git a/lib/checkassert.cpp b/lib/checkassert.cpp
@@ -78,6 +78,11 @@ void CheckAssertImpl::assertWithSideEffects()
                 continue;
             }
 
+            const Token* parent = tmp->astParent();
+            while (Token::Match(parent, ".|::"))
+                parent = parent->astParent();
+            if (!Token::simpleMatch(parent, "("))
+                continue;
             const Function* f = tmp->function();
             const Scope* scope = f->functionScope;
             if (!scope) {
diff --git a/test/testassert.cpp b/test/testassert.cpp
@@ -147,6 +147,17 @@ class TestAssert : public TestFixture {
               "    assert(g());\n"
               "}\n");
         ASSERT_EQUALS("", errout_str());
+
+        check("int i;\n" // #14973
+              "bool f() {\n"
+              "    i = 0;\n"
+              "    return true;\n"
+              "}\n"
+              "void g() {\n"
+              "    bool (*fp)() = f;\n"
+              "    assert(fp == f);\n"
+              "}\n");
+        ASSERT_EQUALS("", errout_str());
     }
 
     void memberFunctionCallInAssert() {
