Makefile: bail out on invalid HAVE_RULES value

firewave · firewave · commit 0972a047d258 · 2024-03-29T11:22:41.000+01:00
diff --git a/Makefile b/Makefile
@@ -5,7 +5,7 @@ ifndef VERBOSE
 endif
 # To compile with rules, use 'make HAVE_RULES=yes'
 ifndef HAVE_RULES
-    HAVE_RULES=no
+    HAVE_RULES=
 endif
 
 ifndef MATCHCOMPILER
@@ -160,6 +160,8 @@ ifeq ($(HAVE_RULES),yes)
     else
         LIBS=$(shell $(PCRE_CONFIG) --libs)
     endif
+else ifneq ($(HAVE_RULES),)
+    $(error invalid HAVE_RULES value '$(HAVE_RULES)')
 endif
 
 ifndef PREFIX
diff --git a/tools/dmake/dmake.cpp b/tools/dmake/dmake.cpp
@@ -584,7 +584,7 @@ int main(int argc, char **argv)
          << "endif\n";
 
     fout << "# To compile with rules, use 'make HAVE_RULES=yes'\n";
-    makeConditionalVariable(fout, "HAVE_RULES", "no");
+    makeConditionalVariable(fout, "HAVE_RULES", "");
 
     makeMatchcompiler(fout, emptyString, emptyString);
 
@@ -743,6 +743,8 @@ int main(int argc, char **argv)
          << "    else\n"
          << "        LIBS=$(shell $(PCRE_CONFIG) --libs)\n"
          << "    endif\n"
+         << "else ifneq ($(HAVE_RULES),)\n"
+         << "    $(error invalid HAVE_RULES value '$(HAVE_RULES)')\n"
          << "endif\n\n";
 
     makeConditionalVariable(fout, "PREFIX", "/usr");
