Skip to content

Commit b194e72

Browse files
committed
Removed Git SHA1 from version because it won't build using vcpkg
1 parent dadafa1 commit b194e72

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

src/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
# (See accompanying file LICENSE_1_0.txt or copy at
44
# http://www.boost.org/LICENSE_1_0.txt)
55

6-
include(${PROJECT_SOURCE_DIR}/cmake/skyr-url-git.cmake)
7-
8-
skyr_get_git_sha1(skyr-url_VERSION_SHA1)
9-
106
configure_file(
117
version.hpp.in
128
${PROJECT_BINARY_DIR}/include/skyr/version.hpp

src/version.hpp.in

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#define SKYR_VERSION_MAJOR @skyr-url_VERSION_MAJOR@
1616
#define SKYR_VERSION_MINOR @skyr-url_VERSION_MINOR@
1717
#define SKYR_VERSION_PATCH @skyr-url_VERSION_PATCH@
18-
#define SKYR_VERSION_SHA1 "@skyr-url_VERSION_SHA1@"
1918

2019
#define SKYR_VERSION_STRING \
2120
SKYR_PREPROCESSOR_TO_STRING(SKYR_VERSION_MAJOR) "." \
@@ -24,26 +23,25 @@
2423
#define SKYR_RELEASE_STRING \
2524
SKYR_PREPROCESSOR_TO_STRING(SKYR_VERSION_MAJOR) "." \
2625
SKYR_PREPROCESSOR_TO_STRING(SKYR_VERSION_MINOR) "." \
27-
SKYR_PREPROCESSOR_TO_STRING(SKYR_VERSION_PATCH) "-" \
28-
SKYR_VERSION_SHA1
26+
SKYR_PREPROCESSOR_TO_STRING(SKYR_VERSION_PATCH) "-"
2927

3028
namespace skyr {
3129
/// \returns The majo, minor version as a tuple
3230
static constexpr auto version() noexcept -> std::tuple<int, int> {
3331
return {SKYR_VERSION_MAJOR, SKYR_VERSION_MINOR};
3432
}
3533

36-
/// \returns The major, minor, patch and Git sha1 as a tuple
37-
static constexpr auto release() noexcept -> std::tuple<int, int, int, std::string_view> {
38-
return {SKYR_VERSION_MAJOR, SKYR_VERSION_MINOR, SKYR_VERSION_PATCH, SKYR_VERSION_SHA1};
34+
/// \returns The major, minor, patch as a tuple
35+
static constexpr auto release() noexcept -> std::tuple<int, int, int> {
36+
return {SKYR_VERSION_MAJOR, SKYR_VERSION_MINOR, SKYR_VERSION_PATCH};
3937
}
4038

4139
/// \returns The version as a string in the form MAJOR.MINOR
4240
static constexpr auto version_string() noexcept -> std::string_view {
4341
return SKYR_VERSION_STRING;
4442
}
4543

46-
/// \returns The version as a string in the form MAJOR.MINOR.PATCH-SHA1
44+
/// \returns The version as a string in the form MAJOR.MINOR.PATCH
4745
static constexpr auto release_string() noexcept -> std::string_view {
4846
return SKYR_RELEASE_STRING;
4947
}

0 commit comments

Comments
 (0)