Do not catch null pointer exception

bitwiseman · bitwiseman · commit 61fbccf4e9dd · 2022-09-26T23:32:27.000-07:00
diff --git a/src/main/java/org/kohsuke/github/extras/okhttp3/ObsoleteUrlFactory.java b/src/main/java/org/kohsuke/github/extras/okhttp3/ObsoleteUrlFactory.java
@@ -320,7 +320,7 @@ static String getSystemProperty(String key, @Nullable String defaultValue) {
         String value;
         try {
             value = System.getProperty(key);
-        } catch (SecurityException | IllegalArgumentException | NullPointerException ex) {
+        } catch (SecurityException | IllegalArgumentException ex) {
             return defaultValue;
         }
         return value != null ? value : defaultValue;

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,7 @@ static String getSystemProperty(String key, @Nullable String defaultValue) {`
`320`	`320`	`String value;`
`321`	`321`	`try {`
`322`	`322`	`value = System.getProperty(key);`
`323`		`- } catch (SecurityException \| IllegalArgumentException \| NullPointerException ex) {`
	`323`	`+ } catch (SecurityException \| IllegalArgumentException ex) {`
`324`	`324`	`return defaultValue;`
`325`	`325`	`}`
`326`	`326`	`return value != null ? value : defaultValue;`