Skip to content

Commit 02e546b

Browse files
committed
Merge pull request softlayer#688 from sudorandom/issue-660
Returns the new record when calling DNSManager.create_record
2 parents c4f371f + 0ee9732 commit 02e546b

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

SoftLayer/managers/dns.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def create_record(self, zone_id, record, record_type, data, ttl=60):
9292
:param integer ttl: the TTL or time-to-live value (default: 60)
9393
9494
"""
95-
self.record.createObject({
95+
return self.record.createObject({
9696
'domainId': zone_id,
9797
'ttl': ttl,
9898
'host': record,

tests/managers/dns_tests.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ def test_edit_zone(self):
7777
args=('example.com',))
7878

7979
def test_create_record(self):
80-
self.dns_client.create_record(1, 'test', 'TXT', 'testing', ttl=1200)
80+
res = self.dns_client.create_record(1, 'test', 'TXT', 'testing',
81+
ttl=1200)
8182

8283
self.assert_called_with('SoftLayer_Dns_Domain_ResourceRecord',
8384
'createObject',
@@ -88,6 +89,7 @@ def test_create_record(self):
8889
'type': 'TXT',
8990
'data': 'testing'
9091
},))
92+
self.assertEqual(res, {'name': 'example.com'})
9193

9294
def test_delete_record(self):
9395
self.dns_client.delete_record(1)

0 commit comments

Comments
 (0)