Support sorting by relevance in code checking.

klen · klen · commit fbdb8ca1e205 · 2013-12-01T22:49:30.000+07:00
diff --git a/Changelog.rst b/Changelog.rst
@@ -31,7 +31,8 @@ Changelog
         'pymode_rope_goto_def_newwin', 'pymode_rope_always_show_complete_menu'
 
     * Options added:
-        'pymode_rope_regenerate_on_write', 'pymode_rope_completion', 'pymode_rope_complete_on_dot'
+        'pymode_rope_regenerate_on_write', 'pymode_rope_completion', 'pymode_rope_complete_on_dot',
+        'pymode_lint_sort'
 
     * Commands added:
         'PymodeVirtualenv'
diff --git a/doc/pymode.txt b/doc/pymode.txt
@@ -301,6 +301,13 @@ By example you disable all warnings starting from 'W', but want to see warning
 >
     let g:pymode_lint_select = "E501,W0011,W430"
 
+Sort errors by relevance                                  *'g:pymode_lint_sort'*
+If not emply, errors will be sort by defined relevance
+E.g. let g:pymode_lint_sort = ['E', 'C', 'I']  " Errors first 'E',
+after them 'C' and ...
+>
+    let g:pymode_lint_sort = []
+
 Auto open cwindow (quickfix) if any errors has been finded
                                                        *'g:pymode_lint_cwindow'*
 >
diff --git a/plugin/pymode.vim b/plugin/pymode.vim
@@ -103,6 +103,11 @@ call pymode#default("g:pymode_lint_select", "")
 " Auto open cwindow if any errors has been finded
 call pymode#default("g:pymode_lint_cwindow", 1)
 
+" If not emply, errors will be sort by defined relevance
+" E.g. let g:pymode_lint_sort = ['E', 'C', 'I']  " Errors first 'E',
+" after them 'C' and ...
+call pymode#default("g:pymode_lint_sort", [])
+
 " Place error signs
 call pymode#default("g:pymode_lint_signs", 1)
 
@@ -233,6 +238,10 @@ if &compatible
 endif
 filetype plugin on
 
+if exists('+shellslash')
+    set shellslash
+endif
+
 " Disable python-related functionality
 " let g:pymode_python = 'disable'
 " let g:pymode_python = 'python3'
diff --git a/pymode/lint.py b/pymode/lint.py
@@ -32,4 +32,17 @@ def code_check():
         return False
 
     errors = check_path(path, options=options)
+    sort_rules = vim.eval('g:pymode_lint_sort')
+
+    def sort(e):
+        try:
+            print(e.get('type'))
+            return sort_rules.index(e.get('type'))
+        except ValueError:
+            return 999
+
+    if sort_rules:
+        print(sort_rules)
+        errors = sorted(errors, key=sort)
+
     vim.command('call setqflist(%s)' % json.dumps(errors))

Original file line number	Diff line number	Diff line change
`@@ -301,6 +301,13 @@ By example you disable all warnings starting from 'W', but want to see warning`
`301`	`301`	`>`
`302`	`302`	`let g:pymode_lint_select = "E501,W0011,W430"`
`303`	`303`
	`304`	`+Sort errors by relevance 'g:pymode_lint_sort'`
	`305`	`+If not emply, errors will be sort by defined relevance`
	`306`	`+E.g. let g:pymode_lint_sort = ['E', 'C', 'I'] " Errors first 'E',`
	`307`	`+after them 'C' and ...`
	`308`	`+>`
	`309`	`+ let g:pymode_lint_sort = []`
	`310`	`+`
`304`	`311`	`Auto open cwindow (quickfix) if any errors has been finded`
`305`	`312`	`'g:pymode_lint_cwindow'`
`306`	`313`	`>`