factor out insert_into_history

thomasballinger · thomasballinger · commit 8063be3509c0 · 2013-11-22T20:17:31.000-05:00
diff --git a/bpython/repl.py b/bpython/repl.py
@@ -832,21 +832,7 @@ def push(self, s, insert_into_history=True):
         self.buffer.append(s)
 
         if insert_into_history:
-            if self.config.hist_length:
-                histfilename = os.path.expanduser(self.config.hist_file)
-                oldhistory = self.rl_history.entries
-                self.rl_history.entries = []
-                if os.path.exists(histfilename):
-                    self.rl_history.load(histfilename, getpreferredencoding())
-                self.rl_history.append(s)
-                try:
-                    self.rl_history.save(histfilename, getpreferredencoding(), self.config.hist_length)
-                except EnvironmentError, err:
-                    self.interact.notify("Error occured while writing to file %s (%s) " % (histfilename, err.strerror))
-                    self.rl_history.entries = oldhistory
-                    self.rl_history.append(s)
-            else:
-                self.rl_history.append(s)
+            self.insert_into_history(s)
 
         more = self.interp.runsource('\n'.join(self.buffer))
 
@@ -855,6 +841,23 @@ def push(self, s, insert_into_history=True):
 
         return more
 
+    def insert_into_history(self, s):
+        if self.config.hist_length:
+            histfilename = os.path.expanduser(self.config.hist_file)
+            oldhistory = self.rl_history.entries
+            self.rl_history.entries = []
+            if os.path.exists(histfilename):
+                self.rl_history.load(histfilename, getpreferredencoding())
+            self.rl_history.append(s)
+            try:
+                self.rl_history.save(histfilename, getpreferredencoding(), self.config.hist_length)
+            except EnvironmentError, err:
+                self.interact.notify("Error occured while writing to file %s (%s) " % (histfilename, err.strerror))
+                self.rl_history.entries = oldhistory
+                self.rl_history.append(s)
+        else:
+            self.rl_history.append(s)
+
     def undo(self, n=1):
         """Go back in the undo history n steps and call reeavluate()
         Note that in the program this is called "Rewind" because I
