Replace tmpdir with tmp_path in io.registry tests

jerobado · jerobado · commit 87366c29e40c · 2022-10-19T19:49:27.000+08:00
diff --git a/astropy/io/registry/tests/test_registries.py b/astropy/io/registry/tests/test_registries.py
@@ -473,10 +473,10 @@ def test_read_noformat_arbitrary(self, registry, original, fmtcls1):
             "please provide a 'format' argument."
         )
 
-    def test_read_noformat_arbitrary_file(self, tmpdir, registry, original):
+    def test_read_noformat_arbitrary_file(self, tmp_path, registry, original):
         """Tests that all identifier functions can accept arbitrary files"""
         registry._readers.update(original["readers"])
-        testfile = str(tmpdir.join("foo.example"))
+        testfile = tmp_path / "foo.example"
         with open(testfile, "w") as f:
             f.write("Hello world")
 
@@ -528,7 +528,7 @@ def test_read_format_noreader(self, registry, fmtcls1):
             f"No reader defined for format '{fmt}' and class '{cls.__name__}'"
         )
 
-    def test_read_identifier(self, tmpdir, registry, fmtcls1, fmtcls2):
+    def test_read_identifier(self, tmp_path, registry, fmtcls1, fmtcls2):
         fmt1, cls = fmtcls1
         fmt2, _ = fmtcls2
 
@@ -543,15 +543,15 @@ def test_read_identifier(self, tmpdir, registry, fmtcls1, fmtcls2):
         # the reader. The registry.get_reader will fail but the error message
         # will tell us if the identifier worked.
 
-        filename = tmpdir.join("testfile.a").strpath
+        filename = tmp_path / "testfile.a"
         open(filename, "w").close()
         with pytest.raises(IORegistryError) as exc:
             cls.read(filename, registry=registry)
         assert str(exc.value).startswith(
             f"No reader defined for format '{fmt1}' and class '{cls.__name__}'"
         )
 
-        filename = tmpdir.join("testfile.b").strpath
+        filename = tmp_path / "testfile.b"
         open(filename, "w").close()
         with pytest.raises(IORegistryError) as exc:
             cls.read(filename, registry=registry)
@@ -571,7 +571,7 @@ def test_read_non_existing_unknown_ext(self, fmtcls1):
         with pytest.raises(OSError):
             data = fmtcls1[1].read("non-existing-file-with-unknown.ext")
 
-    def test_read_directory(self, tmpdir, registry, fmtcls1):
+    def test_read_directory(self, tmp_path, registry, fmtcls1):
         """
         Regression test for a bug that caused the I/O registry infrastructure to
         not work correctly for datasets that are represented by folders as
@@ -583,7 +583,7 @@ def test_read_directory(self, tmpdir, registry, fmtcls1):
         )
         registry.register_reader("test_folder_format", cls, empty_reader)
 
-        filename = tmpdir.mkdir("folder_dataset").strpath
+        (filename := tmp_path / "folder_dataset").mkdir()
 
         # With the format explicitly specified
         dataset = cls.read(filename, format="test_folder_format", registry=registry)
@@ -839,10 +839,10 @@ def test_write_noformat_arbitrary(self, registry, original, fmtcls1):
             "please provide a 'format' argument."
         )
 
-    def test_write_noformat_arbitrary_file(self, tmpdir, registry, original):
+    def test_write_noformat_arbitrary_file(self, tmp_path, registry, original):
         """Tests that all identifier functions can accept arbitrary files"""
         registry._writers.update(original["writers"])
-        testfile = str(tmpdir.join("foo.example"))
+        testfile = tmp_path / "foo.example"
 
         with pytest.raises(IORegistryError) as exc:
             Table().write(testfile, registry=registry)
@@ -1116,7 +1116,7 @@ class MyTable(Table):
         mt.write(buffer, format="ascii")
         assert buffer.getvalue() == os.linesep.join(["a b", "1 2", ""])
 
-    def test_read_table_subclass_with_columns_attributes(self, tmpdir):
+    def test_read_table_subclass_with_columns_attributes(self, tmp_path):
         """Regression test for https://github.com/astropy/astropy/issues/7181"""
 
         class MTable(Table):
@@ -1127,7 +1127,7 @@ class MTable(Table):
         mt["a"].format = ".4f"
         mt["a"].description = "hello"
 
-        testfile = str(tmpdir.join("junk.fits"))
+        testfile = tmp_path / "junk.fits"
         mt.write(testfile, overwrite=True)
 
         t = MTable.read(testfile)
