Adding failing test for new feature (Issue #68)

gsscoder · gsscoder · commit da959b700842 · 2015-06-10T11:58:30.000+02:00
diff --git a/src/CommandLine.Tests/CommandLine.Tests.csproj b/src/CommandLine.Tests/CommandLine.Tests.csproj
@@ -62,6 +62,7 @@
     <Compile Include="Fakes\FakeOptionsWithDouble.cs" />
     <Compile Include="Fakes\FakeOptionsWithEnum.cs" />
     <Compile Include="Fakes\FakeOptionsWithMetaValue.cs" />
+    <Compile Include="Fakes\FakeOptionsWithSequenceAndSeparator.cs" />
     <Compile Include="Fakes\FakeOptionsWithSequenceWithoutRange.cs" />
     <Compile Include="Fakes\FakeOptionsWithSets.cs" />
     <Compile Include="Fakes\FakeOptionsWithValues.cs" />
diff --git a/src/CommandLine.Tests/Fakes/FakeOptionsWithSequenceAndSeparator.cs b/src/CommandLine.Tests/Fakes/FakeOptionsWithSequenceAndSeparator.cs
@@ -0,0 +1,13 @@
+﻿using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+
+namespace CommandLine.Tests.Fakes
+{
+    class FakeOptionsWithSequenceAndSeparator
+    {
+        [Option("string-seq", Separator=";")]
+        public IEnumerable<string> StringSequence { get; set; }
+    }
+}
diff --git a/src/CommandLine.Tests/Unit/Core/InstanceBuilderTests.cs b/src/CommandLine.Tests/Unit/Core/InstanceBuilderTests.cs
@@ -162,9 +162,9 @@ public void Parse_sequence_value_without_range_constraints()
         {
             // Fixture setup
             var expectedResult = new FakeOptionsWithSequenceWithoutRange
-            {
-                LongSequence = new[] { 1L, 2L, 3L, 4L, 5L, 6L }
-            };
+                {
+                    LongSequence = new[] { 1L, 2L, 3L, 4L, 5L, 6L }
+                };
 
             // Exercize system 
             var result = InstanceBuilder.Build(
@@ -179,6 +179,28 @@ public void Parse_sequence_value_without_range_constraints()
             // Teardown
         }
 
+        [Fact]
+        public void Parse_string_sequence_with_separator()
+        {
+            // Fixture setup
+            var expectedResult = new FakeOptionsWithSequenceAndSeparator
+                {
+                    StringSequence = new[] { "abc","1234","xyz@aaa.com" }
+                };
+
+            // Exercize system
+            var result = InstanceBuilder.Build(
+                () => new FakeOptionsWithSequenceAndSeparator(),
+                new[] { "abc;1234;xyz@aaa.com" },
+                StringComparer.Ordinal,
+                CultureInfo.InvariantCulture);
+
+            // Verify outcome
+            expectedResult.ShouldHave().AllProperties().EqualTo(result.Value);
+
+            // Teardown
+        }
+
         /// <summary>
         /// https://github.com/gsscoder/commandline/issues/31
         /// </summary>
diff --git a/src/CommandLine/OptionAttribute.cs b/src/CommandLine/OptionAttribute.cs
@@ -16,6 +16,7 @@ public sealed class OptionAttribute : Attribute
         private string setName;
         private int min;
         private int max;
+        private string separator;
         private object defaultValue;
         private string helpText;
         private string metaValue;
@@ -147,6 +148,20 @@ public int Max
             }
         }
 
+        public string Separator
+        {
+            get { return this.separator; }
+            set
+            {
+                if (value == null)
+                {
+                    throw new ArgumentNullException("value");
+                }
+
+                this.setName = value;
+            }
+        }
+
         /// <summary>
         /// Gets or sets mapped property default value.
         /// </summary>
