Skip to content

Commit 85c9dfd

Browse files
gurukulkarnicomdotlinux
gurukulkarni
authored and
comdotlinux
committed
Improved Package Names and Classes (#1)
1 parent 28d320f commit 85c9dfd

13 files changed

Lines changed: 118 additions & 139 deletions

File tree

‎.github/workflows/maven.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: JavaCI
1+
name: Maven_CI_Build
22

33
on: [push]
44

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# java-design-patterns
22

3-
[![Actions Status](https://github.com/comdotlinux/java-design-patterns/workflows/JavaCI/badge.svg)](https://github.com/comdotlinux/java-design-patterns/actions)
3+
[![Actions Status](https://github.com/comdotlinux/java-design-patterns/workflows/Maven_CI_Build/badge.svg)](https://github.com/comdotlinux/java-design-patterns/actions)
44

55
My Implementations of Common Design Patterns for later reference and display
66

src/main/java/com/linux/designpatterns/adapter/cc/impl/CcOneImpl.java renamed to src/main/java/com/linux/designpatterns/adapter/cc/BasicCcOne.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.linux.designpatterns.adapter.cc.impl;
1+
package com.linux.designpatterns.adapter.cc;
22

33
import java.math.BigDecimal;
44

@@ -10,7 +10,7 @@
1010
* @author Guruprasad Kulkarni <guru@linux.com>
1111
*
1212
*/
13-
public class CcOneImpl implements CcOne {
13+
public class BasicCcOne implements CcOne {
1414

1515
private String creditCardNo;
1616
private String customerName;

‎src/main/java/com/linux/designpatterns/adapter/cc/CcOne.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
*
1010
*/
1111
public interface CcOne {
12-
1312
public String getCreditCardNo();
1413
public String getCustomerName();
1514
public String getCardExpMonth();

src/main/java/com/linux/designpatterns/adapter/cc/impl/CcOneToCcTwoAdapter.java renamed to src/main/java/com/linux/designpatterns/adapter/cc/CcOneToCcTwoAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.linux.designpatterns.adapter.cc.impl;
1+
package com.linux.designpatterns.adapter.cc;
22

33
import com.linux.designpatterns.adapter.cc.CcOne;
44
import com.linux.designpatterns.adapter.cc.CcTwo;

‎src/main/java/com/linux/designpatterns/adapter/cc/CcTwo.java‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,14 @@
88
*
99
*/
1010
public interface CcTwo {
11-
1211
public String getCustCardNo();
13-
1412
public String getCardOwnerName();
15-
1613
public String getCardExpMonthDate();
17-
1814
public Integer getCVVNo();
19-
2015
public Double getTotalAmount();
21-
2216
public void setCustCardNo(String custCardNo);
23-
2417
public void setCardOwnerName(String cardOwnerName);
25-
2618
public void setCardExpMonthDate(String cardExpMonthDate);
27-
2819
public void setCVVNo(Integer cVVNo);
29-
3020
public void setTotalAmount(Double totalAmount);
3121
}

src/main/java/com/linux/designpatterns/facade/log/impl/SimpleLoggingFacadeImpl.java renamed to src/main/java/com/linux/designpatterns/facade/log/SimpleLoggingFacadeImpl.java

Lines changed: 74 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -1,74 +1,74 @@
1-
package com.linux.designpatterns.facade.log.impl;
2-
3-
import java.util.Date;
4-
5-
import com.linux.designpatterns.facade.enums.LogLevel;
6-
import com.linux.designpatterns.facade.log.Logger;
7-
import com.linux.designpatterns.facade.log.SimpleLoggingFacade;
8-
9-
/**
10-
* Implementation of {@linkplain SimpleLoggingFacade}
11-
*
12-
* @author Guruprasad Kulkarni <guru@linux.com>
13-
*/
14-
public class SimpleLoggingFacadeImpl implements SimpleLoggingFacade {
15-
16-
private final Logger logger;
17-
private Date logDate;
18-
private boolean useSystemDate = false;
19-
private String pattern;
20-
private String patternAppender;
21-
private char logSeperator;
22-
23-
public SimpleLoggingFacadeImpl(Logger logger) {
24-
this.logger = logger;
25-
}
26-
27-
@Override
28-
public Logger getLogger() {
29-
return logger;
30-
}
31-
32-
@Override
33-
public void setDate(Date logDate) {
34-
this.logDate = logDate;
35-
36-
}
37-
38-
@Override
39-
public void useSystemDate() {
40-
this.useSystemDate = true;
41-
}
42-
43-
@Override
44-
public void setDatePattern(String pattern) {
45-
this.pattern = pattern;
46-
47-
}
48-
49-
@Override
50-
public void setExtraInformation(String patternAppender) {
51-
this.patternAppender = patternAppender;
52-
53-
}
54-
55-
@Override
56-
public void setLogMessageSeperator(char logSeperator) {
57-
this.logSeperator = logSeperator;
58-
59-
}
60-
61-
@Override
62-
public void log(LogLevel logLevel, String logMessage) {
63-
this.logger.log(logLevel, useSystemDate ? new Date() : logDate, pattern, patternAppender, logSeperator,
64-
logMessage);
65-
}
66-
67-
@Override
68-
public void log(LogLevel logLevel, String logMessage, Throwable throwable) {
69-
this.logger.log(logLevel, useSystemDate ? new Date() : logDate, pattern, patternAppender, logSeperator,
70-
throwable, logMessage);
71-
72-
}
73-
74-
}
1+
package com.linux.designpatterns.facade.log;
2+
3+
import java.util.Date;
4+
5+
import com.linux.designpatterns.facade.enums.LogLevel;
6+
import com.linux.designpatterns.facade.log.Logger;
7+
import com.linux.designpatterns.facade.log.SimpleLoggingFacade;
8+
9+
/**
10+
* Implementation of {@linkplain SimpleLoggingFacade}
11+
*
12+
* @author Guruprasad Kulkarni <guru@linux.com>
13+
*/
14+
public class SimpleLoggingFacadeImpl implements SimpleLoggingFacade {
15+
16+
private final Logger logger;
17+
private Date logDate;
18+
private boolean useSystemDate = false;
19+
private String pattern;
20+
private String patternAppender;
21+
private char logSeperator;
22+
23+
public SimpleLoggingFacadeImpl(Logger logger) {
24+
this.logger = logger;
25+
}
26+
27+
@Override
28+
public Logger getLogger() {
29+
return logger;
30+
}
31+
32+
@Override
33+
public void setDate(Date logDate) {
34+
this.logDate = logDate;
35+
36+
}
37+
38+
@Override
39+
public void useSystemDate() {
40+
this.useSystemDate = true;
41+
}
42+
43+
@Override
44+
public void setDatePattern(String pattern) {
45+
this.pattern = pattern;
46+
47+
}
48+
49+
@Override
50+
public void setExtraInformation(String patternAppender) {
51+
this.patternAppender = patternAppender;
52+
53+
}
54+
55+
@Override
56+
public void setLogMessageSeperator(char logSeperator) {
57+
this.logSeperator = logSeperator;
58+
59+
}
60+
61+
@Override
62+
public void log(LogLevel logLevel, String logMessage) {
63+
this.logger.log(logLevel, useSystemDate ? new Date() : logDate, pattern, patternAppender, logSeperator,
64+
logMessage);
65+
}
66+
67+
@Override
68+
public void log(LogLevel logLevel, String logMessage, Throwable throwable) {
69+
this.logger.log(logLevel, useSystemDate ? new Date() : logDate, pattern, patternAppender, logSeperator,
70+
throwable, logMessage);
71+
72+
}
73+
74+
}

src/main/java/com/linux/designpatterns/facade/log/impl/LoggerImpl.java renamed to src/main/java/com/linux/designpatterns/facade/log/SystemOutLogger.java

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,35 @@
1-
package com.linux.designpatterns.facade.log.impl;
2-
3-
import java.text.SimpleDateFormat;
4-
import java.util.Date;
5-
6-
import com.linux.designpatterns.facade.enums.LogLevel;
7-
import com.linux.designpatterns.facade.log.Logger;
8-
/**
9-
* Implementation of {@linkplain Logger} interface
10-
* @author Guruprasad Kulkarni <guru@linux.com>
11-
*/
12-
public class LoggerImpl implements Logger {
13-
14-
@Override
15-
public void log(LogLevel logLevel, Date logDate, String pattern, String patternAppender,char logSeperator, String logMessage) {
16-
StringBuilder builder = new StringBuilder(logLevel.getMessageName()).append(logSeperator);
17-
builder.append(new SimpleDateFormat(pattern).format(logDate)).append(logSeperator);
18-
builder.append(patternAppender).append(logSeperator);
19-
builder.append(logMessage);
20-
System.out.println(builder.toString());
21-
}
22-
23-
@Override
24-
public void log(LogLevel logLevel, Date logDate, String pattern, String patternAppender,char logSeperator, Throwable throwable,
25-
String logMessage) {
26-
StringBuilder builder = new StringBuilder(logLevel.getMessageName()).append(logSeperator);
27-
builder.append(new SimpleDateFormat(pattern).format(logDate)).append(logSeperator);
28-
builder.append(patternAppender).append(logSeperator);
29-
builder.append(logMessage).append(logSeperator);
30-
builder.append(throwable.getMessage());
31-
System.out.println(builder.toString());
32-
33-
}
34-
35-
}
1+
package com.linux.designpatterns.facade.log;
2+
3+
import java.text.SimpleDateFormat;
4+
import java.util.Date;
5+
6+
import com.linux.designpatterns.facade.enums.LogLevel;
7+
import com.linux.designpatterns.facade.log.Logger;
8+
/**
9+
* Implementation of {@linkplain Logger} interface
10+
* @author Guruprasad Kulkarni <guru@linux.com>
11+
*/
12+
public class SystemOutLogger implements Logger {
13+
14+
@Override
15+
public void log(LogLevel logLevel, Date logDate, String pattern, String patternAppender,char logSeperator, String logMessage) {
16+
StringBuilder builder = new StringBuilder(logLevel.getMessageName()).append(logSeperator);
17+
builder.append(new SimpleDateFormat(pattern).format(logDate)).append(logSeperator);
18+
builder.append(patternAppender).append(logSeperator);
19+
builder.append(logMessage);
20+
System.out.println(builder.toString());
21+
}
22+
23+
@Override
24+
public void log(LogLevel logLevel, Date logDate, String pattern, String patternAppender,char logSeperator, Throwable throwable,
25+
String logMessage) {
26+
StringBuilder builder = new StringBuilder(logLevel.getMessageName()).append(logSeperator);
27+
builder.append(new SimpleDateFormat(pattern).format(logDate)).append(logSeperator);
28+
builder.append(patternAppender).append(logSeperator);
29+
builder.append(logMessage).append(logSeperator);
30+
builder.append(throwable.getMessage());
31+
System.out.println(builder.toString());
32+
33+
}
34+
35+
}

src/main/java/com/linux/designpatterns/observerobservable/impl/SimpleObservable.java renamed to src/main/java/com/linux/designpatterns/observerobservable/SimpleObservable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.linux.designpatterns.observerobservable.impl;
1+
package com.linux.designpatterns.observerobservable;
22

33
import com.linux.designpatterns.observerobservable.Observable;
44
import com.linux.designpatterns.observerobservable.Observer;

src/main/java/com/linux/designpatterns/observerobservable/impl/SimpleObserver.java renamed to src/main/java/com/linux/designpatterns/observerobservable/SimpleObserver.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
* To change this template file, choose Tools | Templates
44
* and open the template in the editor.
55
*/
6-
package com.linux.designpatterns.observerobservable.impl;
6+
package com.linux.designpatterns.observerobservable;
77

8-
import com.linux.designpatterns.observerobservable.Observer;
98
import org.apache.commons.lang3.builder.EqualsBuilder;
109
import org.apache.commons.lang3.builder.HashCodeBuilder;
1110
import org.apache.commons.lang3.builder.ToStringBuilder;

0 commit comments

Comments
 (0)