I18N: Merge duplicate strings in notifications displayed when a new user has been created or added to the site.

SergeyBiryukov · SergeyBiryukov · commit 69fabdbd4d77 · 2019-06-15T18:56:47.000Z
Props ramiy. Fixes #35746. git-svn-id: https://develop.svn.wordpress.org/trunk@45542 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/network/user-new.php b/src/wp-admin/network/user-new.php
@@ -86,12 +86,17 @@
 			}
 		}
 
-		if ( empty( $edit_link ) ) {
-			$messages[] = __( 'User added.' );
-		} else {
-			/* translators: %s: edit page url */
-			$messages[] = sprintf( __( 'User added. <a href="%s">Edit user</a>' ), $edit_link );
+		$message = __( 'User added.' );
+
+		if ( $edit_link ) {
+			$message .= sprintf(
+				' <a href="%s">%s</a>',
+				$edit_link,
+				__( 'Edit user' )
+			);
 		}
+
+		$messages[] = $message;
 	}
 }
 
diff --git a/src/wp-admin/user-new.php b/src/wp-admin/user-new.php
@@ -293,12 +293,17 @@
 				$messages[] = __( 'Invitation email sent to user. A confirmation link must be clicked for them to be added to your site.' );
 				break;
 			case 'addnoconfirmation':
-				if ( empty( $edit_link ) ) {
-					$messages[] = __( 'User has been added to your site.' );
-				} else {
-					/* translators: %s: edit page url */
-					$messages[] = sprintf( __( 'User has been added to your site. <a href="%s">Edit user</a>' ), $edit_link );
+				$message = __( 'User has been added to your site.' );
+
+				if ( $edit_link ) {
+					$message .= sprintf(
+						' <a href="%s">%s</a>',
+						$edit_link,
+						__( 'Edit user' )
+					);
 				}
+
+				$messages[] = $message;
 				break;
 			case 'addexisting':
 				$messages[] = __( 'That user is already a member of this site.' );
diff --git a/src/wp-admin/users.php b/src/wp-admin/users.php
@@ -483,21 +483,23 @@
 					$messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . sprintf( $message, number_format_i18n( $delete_count ) ) . '</p></div>';
 					break;
 				case 'add':
+					$message = __( 'New user created.' );
+
 					if ( isset( $_GET['id'] ) && ( $user_id = $_GET['id'] ) && current_user_can( 'edit_user', $user_id ) ) {
-						/* translators: %s: edit page url */
-						$messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . sprintf(
-							__( 'New user created. <a href="%s">Edit user</a>' ),
+						$message .= sprintf(
+							' <a href="%s">%s</a>',
 							esc_url(
 								add_query_arg(
 									'wp_http_referer',
 									urlencode( wp_unslash( $_SERVER['REQUEST_URI'] ) ),
 									self_admin_url( 'user-edit.php?user_id=' . $user_id )
 								)
-							)
-						) . '</p></div>';
-					} else {
-						$messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __( 'New user created.' ) . '</p></div>';
+							),
+							__( 'Edit user' )
+						);
 					}
+
+					$messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . $message . '</p></div>';
 					break;
 				case 'promote':
 					$messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __( 'Changed roles.' ) . '</p></div>';

Original file line number	Diff line number	Diff line change
`@@ -86,12 +86,17 @@`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`		`- if ( empty( $edit_link ) ) {`
`90`		`- $messages[] = __( 'User added.' );`
`91`		`- } else {`
`92`		`- /* translators: %s: edit page url */`
`93`		`- $messages[] = sprintf( __( 'User added. <a href="%s">Edit user</a>' ), $edit_link );`
	`89`	`+ $message = __( 'User added.' );`
	`90`	`+`
	`91`	`+ if ( $edit_link ) {`
	`92`	`+ $message .= sprintf(`
	`93`	`+ ' <a href="%s">%s</a>',`
	`94`	`+ $edit_link,`
	`95`	`+ __( 'Edit user' )`
	`96`	`+ );`
`94`	`97`	`}`
	`98`	`+`
	`99`	`+ $messages[] = $message;`
`95`	`100`	`}`
`96`	`101`	`}`
`97`	`102`