You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi thanks for your proposal, but this change might break the existing functionalities for the library or application using chrono because there is already a function with the same name.
The issue is still perfectly valid though. You haven't resolved it at all. It is pretty silly to have to spell out each field. Just add another method to simplify life for people. Or not... it seems like you're not updating this library at all anyway.
Yeap, this is valid issue but we cannot change the existing function signature. that's why I had close this this issue. however this issue actually arise again, we can add a function named AtTime. It will take in time.Time as a parameter.
Activity
burakkoken commentedon Oct 10, 2021
Hi thanks for your proposal, but this change might break the existing functionalities for the library or application using chrono because there is already a function with the same name.
lookfirst commentedon Oct 10, 2021
Obviously, need another method name. You're taking the 'proposal' too literal.
burakkoken commentedon Dec 11, 2021
For now, this change will not be made. that's why closing the issue.
lookfirst commentedon Dec 13, 2021
The issue is still perfectly valid though. You haven't resolved it at all. It is pretty silly to have to spell out each field. Just add another method to simplify life for people. Or not... it seems like you're not updating this library at all anyway.
[-]Add WithStartTime(time.Time)[/-][+]Add Function AtTime(time.Time)[/+]burakkoken commentedon Dec 14, 2021
Yeap, this is valid issue but we cannot change the existing function signature. that's why I had close this this issue. however this issue actually arise again, we can add a function named AtTime. It will take in
time.Timeas a parameter.burakkoken commentedon Mar 24, 2022
@lookfirst With new release version 1.1.0, I have added WithTime method that takes in time.Time parameter. WithStartTime is deprecated now. fyi
lookfirst commentedon Mar 24, 2022
@burakkoken 166 days, not bad. Thanks!