Fix clippy

coolreader18 · coolreader18 · commit 1da239ac0809 · 2021-11-15T16:08:47.000-06:00
diff --git a/common/src/atomic.rs b/common/src/atomic.rs
@@ -56,6 +56,12 @@ pub struct OncePtr<T> {
     inner: PyAtomic<*mut T>,
 }
 
+impl<T> Default for OncePtr<T> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<T> OncePtr<T> {
     #[inline]
     pub fn new() -> Self {
diff --git a/common/src/linked_list.rs b/common/src/linked_list.rs
@@ -245,7 +245,7 @@ impl<L: Link> LinkedList<L, L::Target> {
 
     // === rustpython additions ===
 
-    pub fn iter<'a>(&'a self) -> impl Iterator<Item = &'a L::Target> {
+    pub fn iter(&self) -> impl Iterator<Item = &L::Target> {
         std::iter::successors(self.head, |node| unsafe {
             L::pointers(*node).as_ref().get_next()
         })
diff --git a/vm/src/dictdatatype.rs b/vm/src/dictdatatype.rs
@@ -605,7 +605,7 @@ impl<T: Clone> Dict<T> {
         };
         match slot {
             Some(entry) if entry.index == index_index => {
-                if pred(&entry.value)? == false {
+                if !pred(&entry.value)? {
                     return Ok(ControlFlow::Break(None));
                 }
             }
diff --git a/vm/src/pyobjectrc.rs b/vm/src/pyobjectrc.rs
@@ -265,7 +265,7 @@ impl WeakRefList {
 }
 
 impl WeakListInner {
-    fn iter<'a>(&'a self) -> impl Iterator<Item = &'a PyObjectView<PyWeak>> {
+    fn iter(&self) -> impl Iterator<Item = &PyObjectView<PyWeak>> {
         self.list.iter().filter(|wr| wr.0.refcount.get() > 0)
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -605,7 +605,7 @@ impl<T: Clone> Dict<T> {`
`605`	`605`	`};`
`606`	`606`	`match slot {`
`607`	`607`	`Some(entry) if entry.index == index_index => {`
`608`		`- if pred(&entry.value)? == false {`
	`608`	`+ if !pred(&entry.value)? {`
`609`	`609`	`return Ok(ControlFlow::Break(None));`
`610`	`610`	`}`
`611`	`611`	`}`
Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ impl WeakRefList {`
`265`	`265`	`}`
`266`	`266`
`267`	`267`	`impl WeakListInner {`
`268`		`- fn iter<'a>(&'a self) -> impl Iterator<Item = &'a PyObjectView<PyWeak>> {`
	`268`	`+ fn iter(&self) -> impl Iterator<Item = &PyObjectView<PyWeak>> {`
`269`	`269`	`self.list.iter().filter(\|wr\| wr.0.refcount.get() > 0)`
`270`	`270`	`}`
`271`	`271`	`}`