fixed default values of pymode_lint_ignore and pymode_lint_select to be lists

fmv1992 · fmv1992 · commit 13666d8c6236 · 2017-11-19T01:01:58.000-02:00
diff --git a/doc/pymode.txt b/doc/pymode.txt
@@ -317,7 +317,7 @@ Select some error or warnings.                           *'g:pymode_lint_select'
 By example you disable all warnings starting from 'W', but want to see warning
 'W0011' and warning 'W430'
 >
-    let g:pymode_lint_select = "E501,W0011,W430"
+    let g:pymode_lint_select = ["E501", "W0011", "W430"]
 
 Sort errors by relevance                                   *'g:pymode_lint_sort'*
 If not empty, errors will be sort by defined relevance
diff --git a/plugin/pymode.vim b/plugin/pymode.vim
@@ -111,10 +111,10 @@ call pymode#default("g:pymode_lint_message", 1)
 call pymode#default("g:pymode_lint_checkers", ['pyflakes', 'pep8', 'mccabe'])
 
 " Skip errors and warnings (e.g. E4,W)
-call pymode#default("g:pymode_lint_ignore", "")
+call pymode#default("g:pymode_lint_ignore", [])
 
 " Select errors and warnings (e.g. E4,W)
-call pymode#default("g:pymode_lint_select", "")
+call pymode#default("g:pymode_lint_select", [])
 
 " Auto open cwindow if any errors has been finded
 call pymode#default("g:pymode_lint_cwindow", 1)
diff --git a/pymode/__init__.py b/pymode/__init__.py
@@ -18,7 +18,7 @@ class Options(object):
         aggressive = 1
         diff = False
         experimental = True
-        ignore = vim.eval('g:pymode_lint_ignore').split(',')
+        ignore = vim.eval('g:pymode_lint_ignore')
         in_place = True
         indent_size = int(vim.eval('&tabstop'))
         line_range = None
diff --git a/pymode/lint.py b/pymode/lint.py
@@ -36,12 +36,10 @@ def code_check():
         # DEPRECATE: v:0.10.0: need to be set as lists.
         if isinstance(env.var('g:pymode_lint_ignore'), str):
             raise ValueError ('g:pymode_lint_ignore should have a list type')
-            ignore = env.var('g:pymode_lint_ignore').split(',')
         else:
             ignore = env.var('g:pymode_lint_ignore')
         if isinstance(env.var('g:pymode_lint_select'), str):
-            raise ValueError ('g:pymode_lint_ignore should have a list type')
-            select = env.var('g:pymode_lint_select').split(',')
+            raise ValueError ('g:pymode_lint_select should have a list type')
         else:
             select = env.var('g:pymode_lint_select')
         options = parse_options(

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,7 @@ Select some error or warnings. *'g:pymode_lint_select'`
`317`	`317`	`By example you disable all warnings starting from 'W', but want to see warning`
`318`	`318`	`'W0011' and warning 'W430'`
`319`	`319`	`>`
`320`		`- let g:pymode_lint_select = "E501,W0011,W430"`
	`320`	`+ let g:pymode_lint_select = ["E501", "W0011", "W430"]`
`321`	`321`
`322`	`322`	`Sort errors by relevance 'g:pymode_lint_sort'`
`323`	`323`	`If not empty, errors will be sort by defined relevance`