Check for valid HTTP 2xx responses

remarcmij · remarcmij · commit d215b6756d86 · 2019-07-17T23:08:57.000+02:00
diff --git a/homework-classes/App.js b/homework-classes/App.js
@@ -75,5 +75,4 @@ class App {
 }
 
 const HYF_REPOS_URL = 'https://api.github.com/orgs/HackYourFuture/repos?per_page=100';
-
 window.onload = () => new App(HYF_REPOS_URL);
diff --git a/homework-classes/Util.js b/homework-classes/Util.js
@@ -22,7 +22,7 @@ class Util {
       xhr.open('GET', url);
       xhr.responseType = 'json';
       xhr.onload = () => {
-        if (xhr.status < 400) {
+        if (xhr.status >= 200 && xhr.status <= 299) {
           resolve(xhr.response);
         } else {
           reject(new Error(`Network error: ${xhr.status} - ${xhr.statusText}`));
diff --git a/homework/index.js b/homework/index.js
@@ -6,7 +6,7 @@
     xhr.open('GET', url);
     xhr.responseType = 'json';
     xhr.onload = () => {
-      if (xhr.status < 400) {
+      if (xhr.status >= 200 && xhr.status <= 299) {
         cb(null, xhr.response);
       } else {
         cb(new Error(`Network error: ${xhr.status} - ${xhr.statusText}`));
@@ -42,6 +42,5 @@
   }
 
   const HYF_REPOS_URL = 'https://api.github.com/orgs/HackYourFuture/repos?per_page=100';
-
   window.onload = () => main(HYF_REPOS_URL);
 }

Original file line number	Diff line number	Diff line change
`@@ -75,5 +75,4 @@ class App {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`const HYF_REPOS_URL = 'https://api.github.com/orgs/HackYourFuture/repos?per_page=100';`
`78`		`-`
`79`	`78`	`window.onload = () => new App(HYF_REPOS_URL);`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`xhr.open('GET', url);`
`7`	`7`	`xhr.responseType = 'json';`
`8`	`8`	`xhr.onload = () => {`
`9`		`- if (xhr.status < 400) {`
	`9`	`+ if (xhr.status >= 200 && xhr.status <= 299) {`
`10`	`10`	`cb(null, xhr.response);`
`11`	`11`	`} else {`
`12`	`12`	cb(new Error(`Network error: ${xhr.status} - ${xhr.statusText}`));
`@@ -42,6 +42,5 @@`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`const HYF_REPOS_URL = 'https://api.github.com/orgs/HackYourFuture/repos?per_page=100';`
`45`		`-`
`46`	`45`	`window.onload = () => main(HYF_REPOS_URL);`
`47`	`46`	`}`