tweak(server/launcher): detect and cleanly fail on unsupported CPUs

blattersturm · blattersturm · commit 7f730917abb0 · 2022-11-28T13:34:17.000+01:00
There's a fair amount of old x86 CPUs floating around and every so often someone hits an 'illegal instruction' crash which is a bit confusing. See: - https://forum.cfx.re/t/4947054 - https://forum.cfx.re/t/4837037/4 - https://forum.cfx.re/t/4777623 and so on.
diff --git a/.gitmodules b/.gitmodules
@@ -277,3 +277,6 @@
 [submodule "vendor/nljson"]
 	path = vendor/nljson
 	url = https://github.com/nlohmann/json.git
+[submodule "vendor/cpu_features"]
+	path = vendor/cpu_features
+	url = https://github.com/google/cpu_features.git
diff --git a/code/server/launcher/premake5.lua b/code/server/launcher/premake5.lua
@@ -4,7 +4,7 @@
 
 		links { "Shared", "CitiCore" }
 
-		add_dependencies { 'vendor:fmtlib', 'vendor:breakpad' }
+		add_dependencies { 'vendor:fmtlib', 'vendor:breakpad', 'vendor:cpu_features' }
 		
 		if os.istarget('windows') then
 			links { "psapi", "wininet", "winhttp" }
diff --git a/code/server/launcher/src/Main.cpp b/code/server/launcher/src/Main.cpp
@@ -14,6 +14,8 @@
 #include <pthread.h>
 #endif
 
+#include "cpuinfo_x86.h"
+
 bool InitializeExceptionHandler(int argc, char* argv[]);
 
 int main(int argc, char* argv[])
@@ -27,6 +29,18 @@ int main(int argc, char* argv[])
 	}
 #endif
 
+#ifdef CPU_FEATURES_ARCH_X86
+	auto x86info = cpu_features::GetX86Info();
+	if (!x86info.features.popcnt)
+	{
+		fmt::printf("The Cfx.re Platform Server requires support for x86-64-v2 instructions (such as POPCNT).\n");
+		fmt::printf("Your current CPU (\"%s\") does not appear to support this. Supported CPUs include most CPUs from around 2010 or newer.\n", x86info.brand_string);
+		fmt::printf("\n");
+		fmt::printf("Exiting.\n");
+		return 1;
+	}
+#endif
+
 	if (InitializeExceptionHandler(argc, argv))
 	{
 		return 0;
diff --git a/code/vendor/config.lua b/code/vendor/config.lua
@@ -104,5 +104,6 @@ vendor_component 'dspfilters'
 vendor_component 'speexdsp'
 vendor_component 'wil'
 vendor_component 'v8-93'
+vendor_component 'cpu_features'
 vendor_component 'citizen_enet'
 vendor_component 'citizen_util'
diff --git a/code/vendor/cpu_features.lua b/code/vendor/cpu_features.lua
@@ -0,0 +1,25 @@
+return {
+	include = function()
+		includedirs "../vendor/cpu_features/include/"
+	end,
+
+	run = function()
+		language "C"
+		kind "StaticLib"
+
+		defines { "STACK_LINE_READER_BUFFER_SIZE=1024" }
+
+		files_project "../vendor/cpu_features/" {
+			"src/**.c",
+		}
+
+		if not os.istarget('linux') then
+			removefiles "../vendor/cpu_features/src/hwcaps.c"
+		else
+			defines {
+				"HAVE_STRONG_GETAUXVAL",
+				"HAVE_DLFCN_H"
+			}
+		end
+	end
+}
diff --git a/vendor/cpu_features b/vendor/cpu_features
@@ -0,0 +1 @@
+Subproject commit 4e191a4cc872263c60eb473550e2b7d2965690f9
