graphql-java#325 PR fix ups - clearer javadoc and assertions

bbakerman · bbakerman · commit 9b0a96fd3efb · 2017-04-11T08:07:21.000+10:00
diff --git a/src/main/java/graphql/language/AbstractNode.java b/src/main/java/graphql/language/AbstractNode.java
@@ -4,6 +4,8 @@
 import java.util.Collections;
 import java.util.List;
 
+import static graphql.Assert.assertNotNull;
+
 public abstract class AbstractNode implements Node {
 
     private SourceLocation sourceLocation;
@@ -24,6 +26,7 @@ public List<String> getComments() {
     }
 
     public void setComments(List<String> comments) {
-        this.comments = comments == null ? Collections.emptyList() : comments;
+        assertNotNull(comments, "You must provide non null comments");
+        this.comments = comments;
     }
 }
diff --git a/src/main/java/graphql/language/Node.java b/src/main/java/graphql/language/Node.java
@@ -10,7 +10,7 @@ public interface Node {
     SourceLocation getSourceLocation();
 
     /**
-     * Nodes can have comments made on them
+     * Nodes can have comments made on them, the following is one comment per line before a node.
      *
      * @return the list of comments or an empty list of there are none
      */

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@`
`4`	`4`	`import java.util.Collections;`
`5`	`5`	`import java.util.List;`
`6`	`6`
	`7`	`+import static graphql.Assert.assertNotNull;`
	`8`	`+`
`7`	`9`	`public abstract class AbstractNode implements Node {`
`8`	`10`
`9`	`11`	`private SourceLocation sourceLocation;`
`@@ -24,6 +26,7 @@ public List<String> getComments() {`
`24`	`26`	`}`
`25`	`27`
`26`	`28`	`public void setComments(List<String> comments) {`
`27`		`- this.comments = comments == null ? Collections.emptyList() : comments;`
	`29`	`+ assertNotNull(comments, "You must provide non null comments");`
	`30`	`+ this.comments = comments;`
`28`	`31`	`}`
`29`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ public interface Node {`
`10`	`10`	`SourceLocation getSourceLocation();`
`11`	`11`
`12`	`12`	`/**`
`13`		`- * Nodes can have comments made on them`
	`13`	`+ * Nodes can have comments made on them, the following is one comment per line before a node.`
`14`	`14`	`*`
`15`	`15`	`* @return the list of comments or an empty list of there are none`
`16`	`16`	`*/`